| Summary: | Prevent removing of Breeze SDDM theme | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_sddm | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander.lohnau, kde, kde, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/sddm-kcm/commit/373260064f64486e008b7294e3de41fabe90a9a6 | Version Fixed In: | 5.25.1 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2022-06-05 13:00:57 UTC
Can reproduce. I also see an inappropriately-enabled delete button for the "Breeze Fedora" theme that was pre-installed by my distro. Confirmed, this is a bit tricky, because all themes are installed in /usr. I will look into it :) >because all themes are installed in /usr.
This is something we could adjust moving forward. It is very stupid.
>This is something we could adjust moving forward
Though the sddm config is in /etc, can we simply use a local path? From a security perspective, that would mean that the computer-wide sddm theme is lying in a user-owned folder. Or maybe we could copy the folder to /usr once a theme is applied. Since the themes are only a few MB large, that should not be a performance problem.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/sddm-kcm/-/merge_requests/29 Git commit 803a5d8b160e1e6201f9ba90b0fd17ed5b9bd5b3 by Alexander Lohnau. Committed on 13/06/2022 at 06:01. Pushed by alex into branch 'master'. Only show delete button for themes that were manually or through KNS installed Rather than just hardcoding breeze, we check if the theme was installed using the sddmthemeinstaller. In case that was done, we have an entry in the config file with the file path. M +1 -0 src/package/contents/ui/main.qml M +4 -0 src/themesmodel.cpp M +2 -0 src/themesmodel.h https://invent.kde.org/plasma/sddm-kcm/commit/803a5d8b160e1e6201f9ba90b0fd17ed5b9bd5b3 Git commit 373260064f64486e008b7294e3de41fabe90a9a6 by Alexander Lohnau. Committed on 13/06/2022 at 06:02. Pushed by alex into branch 'Plasma/5.25'. Only show delete button for themes that were manually or through KNS installed Rather than just hardcoding breeze, we check if the theme was installed using the sddmthemeinstaller. In case that was done, we have an entry in the config file with the file path. (cherry picked from commit 803a5d8b160e1e6201f9ba90b0fd17ed5b9bd5b3) M +1 -0 src/package/contents/ui/main.qml M +4 -0 src/themesmodel.cpp M +2 -0 src/themesmodel.h https://invent.kde.org/plasma/sddm-kcm/commit/373260064f64486e008b7294e3de41fabe90a9a6 |