Bug 454856

Summary:	`ctrl` modifier not reset even after the key has been released.
Product:	[Applications] krita	Reporter:	levi.duncan.self
Component:	Shortcuts and Canvas Input Settings	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73, halla
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description levi.duncan.self 2022-06-04 23:57:28 UTC

The `ctrl` modifier is not cleared even after the key has been released. This results in (eg.) the `Color Picker` tool being chosen (with the default keybinds and `Canvas Input Settings`) until the modifier is reset by alternative means (eg. pressing the `Brush` tool button on the sidebar, or using a keybind which brings up a new window).

Reproduction Steps:
  1. Press the `ctrl` key (be it alone or in a shortcut/chord)
  2. Release the `ctrl` key

Expected outcome:
  The cursor should turn back into the previously used mode (eg. brush)

Actual outcome:
  The cursor stays in the color picker mode

According to my bisect the first commit in which this bug occurs is `d2b028c9fc8dbe427d944f26b34b833607614e4d` (https://invent.kde.org/graphics/krita/-/commit/d2b028c9fc8dbe427d944f26b34b833607614e4d) which was committed as a fix for bug 438784.

System info:
  Operating System: Arch Linux
  KDE Plasma Version: 5.24.5
  KDE Frameworks Version: 5.94.0
  Qt Version: 5.15.4
  Kernel Version: 5.18.1-arch1-1 (64-bit)
  Graphics Platform: X11
  Processors: 16 × AMD Ryzen 7 3700X 8-Core Processor
  Memory: 15.6 GiB of RAM
  Graphics Processor: AMD Radeon RX 5700 XT

Comment 1 levi.duncan.self 2022-06-05 00:33:49 UTC

Additional info:
  Bug exists at master commit (newest as of report): d335b6f7a50dec28f658a2edb26ff60029adfed6 (https://invent.kde.org/graphics/krita/-/commit/d335b6f7a50dec28f658a2edb26ff60029adfed6)

Comment 2 Dmitry Kazakov 2022-06-30 12:27:06 UTC

Hi, Levi!

Have you compiled Krita yourself or used our packages? 

We have fixed this bug by patching Qt in d518783ca601fdc7f4d934cee01067137cc8f08e and d682f0f5b17f64494a718652cb4ea733f725d83c on May 26th, but if you used your own Qt, you didn't receive these fixes. We also added a workaround for non-patched Qt in cfbfc96940e2e30dd2d307f24764cc52aae1d235 on June 10th.

Could you check if you can still reproduce the issue with our nightly builds of Krita?

Comment 3 levi.duncan.self 2022-07-10 21:39:01 UTC

I am very sorry for such a late response.

I have built Krita with my system's Qt. Unfortunately I do not currently have access to my main (Linux) PC, and thus have no way of verifying the fix. I will check the nightly builds as soon as I'll have an opportunity.

Comment 4 Bug Janitor Service 2022-07-11 04:36:42 UTC

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

Comment 5 Dmitry Kazakov 2022-07-11 10:39:51 UTC

Hi, Levi!

Thanks a lot for your reply! I will mark the bug as "waiting for info" until you manage to check the nightly builds :) I hope the bug has already been resolved in the nightly builds :)

Comment 6 Bug Janitor Service 2022-07-26 04:35:45 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 7 levi.duncan.self 2022-08-01 22:20:32 UTC

(In reply to Dmitry Kazakov from comment #5)
> Hi, Levi!
> 
> Thanks a lot for your reply! I will mark the bug as "waiting for info" until
> you manage to check the nightly builds :) I hope the bug has already been
> resolved in the nightly builds :)

I have checked the official nightly builds (commit 9acc61cd19) and they seem to have the correct behaviour (despite my own git builds not doing so).