Summary: | Plasmoid Viewer crashes on exit with clipboard applet | ||
---|---|---|---|
Product: | [Plasma] Plasma SDK | Reporter: | ratijas <me> |
Component: | plasmoidviewer | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | giorgos.tsiapaliokas, nate |
Priority: | NOR | ||
Version First Reported In: | master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=492070 | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
ratijas
2022-06-04 22:15:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/106 Git commit 8e8ef50b9faa3c2365dcf60f9d8dac71c55c0440 by ivan tkachenko. Committed on 23/04/2024 at 18:18. Pushed by ratijas into branch 'master'. Fix connection lifetime issue The lack of receiver may cause undefined behavior / segmentation fault crash if, for example, a KActionCollection is stored as a Q_GLOBAL_STATIC too and coincidentally gets destructed after the KGlobalAccel singleton instance. Note that all other connections in this file use this `q->connect` style and already have a context object set to `q`. Test case: Run `plasmoidviewer -a org.kde.plasma.clipboard`. With this patch is still crashes on exit, but now in a different place. Related: bug 485386 M +1 -1 src/kglobalaccel.cpp https://invent.kde.org/frameworks/kglobalaccel/-/commit/8e8ef50b9faa3c2365dcf60f9d8dac71c55c0440 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma5support/-/merge_requests/25 Could not reproduce anymore. Probably was fixed recently by one of the Fushan's refactorings. Somewhat related: the lifetime management was wrong in plasmoidviewer, though reverting its patch doesn't break things. https://invent.kde.org/plasma/plasma-sdk/-/merge_requests/131 |