| Summary: | Astronomical events calendar plugin now shows an event marker for every day | ||
|---|---|---|---|
| Product: | [Plasma] kdeplasma-addons | Reporter: | Paul Worrall <p.r.worrall> |
| Component: | General | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, vkrause |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.24.90 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/commit/966967d7588933eeb8ab29360625469b82b1bb68 | Version Fixed In: | 5.25 |
| Sentry Crash Report: | |||
|
Description
Paul Worrall
2022-06-03 15:09:33 UTC
So what's going on here is that the Astronomical Events plugin adds these as events. And the Digital Clock shows a dot for every day with an event. Since every day now has an event, every day shows a dot. We have two options: 1. Introduce the concept of the "minor event" or "informational event" that doesn't show a dot on the day, and port the Astronomical Events plugin to use that. 2. Change the Astronomical Events plugin to have fewer events; maybe it's overkill to show an event every single day showing things like "waxing gibbous" Indeed, only showing the four primary phases might make sense. Or we could do both. Ah I see what happened. the Astronomical Events plugin simply consumes data from KHolidays, which added the intermediate phases in 52eb1561be10d21f6dba4a25dafef60c85864b48. CCing Volker who added those. So we have a third option: find a way to filter those out in the Astronomical Events plugin. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/167 Git commit 3f49140aae98e3f1d485e9a4e9657b6cf20f413f by Volker Krause. Committed on 03/06/2022 at 18:34. Pushed by ngraham into branch 'master'. Explicitly list relevant lunar phase events M +2 -1 plasmacalendarplugins/astronomical/astronomicaleventsplugin.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/3f49140aae98e3f1d485e9a4e9657b6cf20f413f Git commit 966967d7588933eeb8ab29360625469b82b1bb68 by Nate Graham, on behalf of Volker Krause. Committed on 03/06/2022 at 18:51. Pushed by ngraham into branch 'Plasma/5.25'. Explicitly list relevant lunar phase events (cherry picked from commit 3f49140aae98e3f1d485e9a4e9657b6cf20f413f) M +2 -1 plasmacalendarplugins/astronomical/astronomicaleventsplugin.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/966967d7588933eeb8ab29360625469b82b1bb68 |