Bug 454741

Summary:	Android: Appearance settings issues
Product:	[Applications] NeoChat	Reporter:	Jan Bidler <janbidler00>
Component:	General	Assignee:	Tobias Fella <fella>
Status:	RESOLVED FIXED
Severity:	normal	CC:	carl, james.h.graham
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Android 7.x
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jan Bidler 2022-06-02 11:13:50 UTC

There are a few issues in the "Appearance" entry in the Settings on Android.

STEPS TO REPRODUCE
1. Open Settings
2. Navigate to "Appearance"

OBSERVED RESULT
1. The "Compact" example is cutting off at the right
2. Checkboxes are hard to tap on 
3. The "Theme" list is completely empty.

EXPECTED RESULT
1. It should not be cut off
2. I don't know if KDE uses something else for Android usually. But having the entries be bigger and maybe registering the touch on the entire line would help
3. Either not show the theme list if there are no themes, or ship themes with NeoChat Android

SOFTWARE/OS VERSIONS
Android: 7.0
NeoChat Version: 22.04
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
I condensed the 3 issues onto one so I don't spam the issue tracker too much. If it's wished for however for all them to be separate issues, let me know and I'll open one for each of them.

Comment 1 Jan Bidler 2022-07-14 15:28:12 UTC

Made a separate issue for 3.: Bug 456676

Comment 2 James Graham 2022-11-19 09:43:03 UTC

https://invent.kde.org/network/neochat/-/merge_requests/640 should deal with 1.

Is the checkbox thing applicable to the other setting tabs with them or just appearance?

Comment 3 Bug Janitor Service 2022-11-21 00:40:59 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/647

Comment 4 Carl Schwan 2022-11-21 15:36:50 UTC

Git commit 3e5421604bd2f99322f37c9c5cefc7072e729cab by Carl Schwan, on behalf of Tobias Fella.
Committed on 21/11/2022 at 15:24.
Pushed by carlschwan into branch 'master'.

Hide inapplicable settings on android
Related: bug 456674, bug 456676

M  +1    -1    src/qml/Settings/AppearanceSettingsPage.qml
M  +1    -0    src/qml/Settings/GeneralSettingsPage.qml
M  +1    -0    src/qml/Settings/SettingsPage.qml

https://invent.kde.org/network/neochat/commit/3e5421604bd2f99322f37c9c5cefc7072e729cab

Comment 5 James Graham 2023-01-04 17:43:43 UTC

I think this can be closed down. 1 is sorted and with the move to mobile form the whole delegate can be clicked rather then just the checkbox itself to flip the state so I don't think it's an issue. Finally 3 has it's own bug so can be tracked there.