| Summary: | Crash upon connecting external Bluetooth headset | ||
|---|---|---|---|
| Product: | [Plasma] plasma-pa | Reporter: | Hynek Mlnarik <hmlnarik> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde, me, nate, nowrep |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 5.24.5 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-pa/commit/b33f3a4c0f4c5b7b7c193370165e799e38c9dddd | Version Fixed In: | 5.24.7 |
|
Description
Hynek Mlnarik
2022-05-31 10:19:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-pa/-/merge_requests/142 A possibly relevant merge request was started @ https://invent.kde.org/libraries/pulseaudio-qt/-/merge_requests/16 Git commit e87f2b13c8701a5d332f7a84fe1a0c344204cbfb by Harald Sitter. Committed on 11/10/2022 at 10:12. Pushed by sitter into branch 'master'. don't crash when the server doesn't respond inside libpulse a non-reply (e.g. caused by a timeout) results in info being a nullptr. when that happens simply skip over the callback. when this happens chances are the server crashed or is otherwise defunct so we won't be able to do much about this anyway easy to test by attaching to both plasmashell and pulseaudio and interrupting the latter when the former calls pa_context_get_server_info. this results in the reply timeout getting hit -> nullptr callback. it is unclear if we can somehow recover from this but in lieu of a reliable real world test case for this we at least shouldn't crash on nullptr access. Related: bug 437272 M +6 -0 src/context.cpp https://invent.kde.org/plasma/plasma-pa/commit/e87f2b13c8701a5d332f7a84fe1a0c344204cbfb Git commit f6b02f21a9131bafc4965ebb64acf01a4505ce04 by Harald Sitter. Committed on 10/10/2022 at 14:06. Pushed by sitter into branch 'master'. don't crash when the server doesn't respond inside libpulse a non-reply (e.g. caused by a timeout) results in info being a nullptr. when that happens simply skip over the callback. when this happens chances are the server crashed or is otherwise defunct so we won't be able to do much about this anyway easy to test by attaching to both plasmashell and pulseaudio and interrupting the latter when the former calls pa_context_get_server_info. this results in the reply timeout getting hit -> nullptr callback. it is unclear if we can somehow recover from this but in lieu of a reliable real world test case for this we at least shouldn't crash on nullptr access. M +6 -0 src/context.cpp https://invent.kde.org/libraries/pulseaudio-qt/commit/f6b02f21a9131bafc4965ebb64acf01a4505ce04 Git commit 89d33990bbd4e63e4624a01fb0e74c341ac50fa4 by Harald Sitter. Committed on 11/10/2022 at 23:58. Pushed by sitter into branch 'Plasma/5.26'. don't crash when the server doesn't respond inside libpulse a non-reply (e.g. caused by a timeout) results in info being a nullptr. when that happens simply skip over the callback. when this happens chances are the server crashed or is otherwise defunct so we won't be able to do much about this anyway easy to test by attaching to both plasmashell and pulseaudio and interrupting the latter when the former calls pa_context_get_server_info. this results in the reply timeout getting hit -> nullptr callback. it is unclear if we can somehow recover from this but in lieu of a reliable real world test case for this we at least shouldn't crash on nullptr access. Related: bug 437272 (cherry picked from commit e87f2b13c8701a5d332f7a84fe1a0c344204cbfb) M +6 -0 src/context.cpp https://invent.kde.org/plasma/plasma-pa/commit/89d33990bbd4e63e4624a01fb0e74c341ac50fa4 Git commit b33f3a4c0f4c5b7b7c193370165e799e38c9dddd by Harald Sitter. Committed on 11/10/2022 at 23:58. Pushed by sitter into branch 'Plasma/5.24'. don't crash when the server doesn't respond inside libpulse a non-reply (e.g. caused by a timeout) results in info being a nullptr. when that happens simply skip over the callback. when this happens chances are the server crashed or is otherwise defunct so we won't be able to do much about this anyway easy to test by attaching to both plasmashell and pulseaudio and interrupting the latter when the former calls pa_context_get_server_info. this results in the reply timeout getting hit -> nullptr callback. it is unclear if we can somehow recover from this but in lieu of a reliable real world test case for this we at least shouldn't crash on nullptr access. Related: bug 437272 (cherry picked from commit e87f2b13c8701a5d332f7a84fe1a0c344204cbfb) M +6 -0 src/context.cpp https://invent.kde.org/plasma/plasma-pa/commit/b33f3a4c0f4c5b7b7c193370165e799e38c9dddd |