Bug 454643

Summary:	QR code button shown on VPN connections
Product:	[Plasma] plasmashell	Reporter:	Nico <nico>
Component:	Networks widget	Assignee:	Jan Grulich <jgrulich>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR	Keywords:	regression
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-nm/commit/b34338bd897581b3c65fb9bc910b3a10f14a9cfd	Version Fixed/Implemented In:	5.25.2
Sentry Crash Report:
Attachments:	QR Code button on vpnc connection

Description Nico 2022-05-31 08:18:03 UTC

SUMMARY
QR code button shown on VPN connections


STEPS TO REPRODUCE
1. Add a VPN
2. Open the applet and click on the arrow to expand

OBSERVED RESULT
QR code option is shown, and it does nothing on click

EXPECTED RESULT
Should not be shown as it's not applicable for VPN connections

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.24.90
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4

ADDITIONAL INFORMATION

Comment 1 Nico 2022-05-31 08:18:38 UTC

Created attachment 149349 [details]
QR Code button on vpnc connection

Comment 2 Bug Janitor Service 2022-06-27 21:17:04 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/131

Comment 3 Nate Graham 2022-06-28 00:22:17 UTC

Git commit 54b5e2f747f1ff4e952f7a3abfba233ddd684849 by Nate Graham, on behalf of Nicolas Fella.
Committed on 28/06/2022 at 00:22.
Pushed by ngraham into branch 'master'.

applet" Fix showing network QR code button only for WiFi networks

This was the case originally until d13233b09af688cc0ec2fe7a89ca249dda51b82d broke it.
Related: bug 453806
FIXED-IN: 5.25.2

M  +5    -7    applet/contents/ui/ConnectionItem.qml

https://invent.kde.org/plasma/plasma-nm/commit/54b5e2f747f1ff4e952f7a3abfba233ddd684849

Comment 4 Nate Graham 2022-06-28 00:24:06 UTC

Git commit b34338bd897581b3c65fb9bc910b3a10f14a9cfd by Nate Graham, on behalf of Nicolas Fella.
Committed on 28/06/2022 at 00:24.
Pushed by ngraham into branch 'Plasma/5.25'.

applet" Fix showing network QR code button only for WiFi networks

This was the case originally until d13233b09af688cc0ec2fe7a89ca249dda51b82d broke it.
Related: bug 453806
FIXED-IN: 5.25.2


(cherry picked from commit 54b5e2f747f1ff4e952f7a3abfba233ddd684849)

M  +5    -7    applet/contents/ui/ConnectionItem.qml

https://invent.kde.org/plasma/plasma-nm/commit/b34338bd897581b3c65fb9bc910b3a10f14a9cfd

Comment 5 Ben Cooksley 2024-12-23 18:25:51 UTC

Bulk transfer as requested in T17796