| Summary: | HSV Adjustment filter value strings have wrong context or cannot be translated | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Translation | Assignee: | Halla Rempt <halla> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, thetwo222 |
| Priority: | NOR | ||
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/6ced2bf81a9683064f249b908bf29972671fd87e | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | HSV Adjustment filter missing translatable strings | ||
In 5.1 beta1, this problem still exists Git commit 3993f43cd43ac6c9d69996703acc1d63ac6c0f99 by Halla Rempt. Committed on 23/06/2022 at 11:34. Pushed by rempt into branch 'master'. M +12 -12 plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp https://invent.kde.org/graphics/krita/commit/3993f43cd43ac6c9d69996703acc1d63ac6c0f99 Git commit 6ced2bf81a9683064f249b908bf29972671fd87e by Halla Rempt. Committed on 23/06/2022 at 11:35. Pushed by rempt into branch 'krita/5.1'. (cherry picked from commit 813edd0d8bd6f3b589044ec197c2037c44b920b3) M +12 -12 plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp https://invent.kde.org/graphics/krita/commit/6ced2bf81a9683064f249b908bf29972671fd87e Thank you, Halla! :) Hi Halla, can you help disambiguate the "Value" in these strings? #: plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp:228 (Value in HSV adjustment) #: plugins/python/scripter/ui_scripter/tabwidgets/debuggerwidget/debuggertable.py:16 (Value as in number) They must be translated differently in CJK languages. I can do that and make a MR if you want, but I think it's less complicated for you to do it. |
Created attachment 149105 [details] HSV Adjustment filter missing translatable strings HSV filter value strings has wrong context or cannot be translated. HSV Value: Wrong context (Value in the context of number) HSL Lightness: Cannot be translated (Missing string) HSI Intensity: Cannot be translated (Missing string) Blue Chroma/Red Chroma/Luma Yellow-Blue, Green-Red: Cannot be translated (Missing string) Tested with: [Affected] krita-5.1.0-prealpha-c356cf83d5-x86_64.appimage (2022-05-22) [Unaffected] krita-5.0.7-a002764931-x86_64.appimage Confirmed under both Simplified Chinese and Traditional Chinese locales, they both have been 100% translated, yet these strings were either missing or broken.