Bug 454197

Summary: Color formatting text left in firmware security view
Product: [Applications] kinfocenter Reporter: kskot <288pat0tem>
Component: Firmware SecurityAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: sitter
Priority: NOR    
Version: 5.24.90   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/plasma/kinfocenter/commit/663a3a804727bfe0e79cf5958c965b241647e514 Version Fixed In:
Sentry Crash Report:
Attachments: color formatting text included in output

Description kskot 2022-05-22 07:46:12 UTC 
Created attachment 149100 [details]
color formatting text included in output

SUMMARY

If the UEFI firmware can not be updated the "Firmware Security" view in the Info Center shows some not-interpreted color formatting text.


STEPS TO REPRODUCE
1. Open Info Center
2. Navigate to Devices -> Firmware Security
3. If firmware can not be updated it shows the text "WARNING: UEFI firmware can not be updated ..." including some color formatting text in front (see enclosed screenshot)

OBSERVED RESULT

Color formatting text included in output

EXPECTED RESULT

Text without the not-interpreted color formatting characters

SOFTWARE/OS VERSIONS
This is on the testing kde neon image (https://files.kde.org/neon/images/testing/20220520-1636/neon-testing-20220520-1636.iso) via a VirtualBox 6.1.
Comment 1 Bug Janitor Service 2022-05-23 09:32:22 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kinfocenter/-/merge_requests/99
Comment 2 Harald Sitter 2022-05-23 10:03:51 UTC 
Git commit c74b4539ce73c849630f4977aa9cc5faa644bd5e by Harald Sitter.
Committed on 23/05/2022 at 09:33.
Pushed by sitter into branch 'master'.

redirect stderr to stdout

otherwise we don't route error output through aha and end up with raw ansi sequences

M  +1    -1    Modules/firmware_security/package/contents/code/fwupdmgr.sh

https://invent.kde.org/plasma/kinfocenter/commit/c74b4539ce73c849630f4977aa9cc5faa644bd5e
Comment 3 Harald Sitter 2022-05-23 10:06:38 UTC 
Git commit 663a3a804727bfe0e79cf5958c965b241647e514 by Harald Sitter.
Committed on 23/05/2022 at 10:06.
Pushed by sitter into branch 'Plasma/5.25'.

redirect stderr to stdout

otherwise we don't route error output through aha and end up with raw ansi sequences


(cherry picked from commit c74b4539ce73c849630f4977aa9cc5faa644bd5e)

M  +1    -1    Modules/firmware_security/package/contents/code/fwupdmgr.sh

https://invent.kde.org/plasma/kinfocenter/commit/663a3a804727bfe0e79cf5958c965b241647e514