| Summary: | User icon sizing is... unusual | ||
|---|---|---|---|
| Product: | [Plasma] kdeplasma-addons | Reporter: | Antonio Rojas <arojas> |
| Component: | User Switcher | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | me, nate, plasma-bugs |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.24.90 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/commit/edef412e0ce0406502b0c21f9d01ff1c7e4d8bca | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: |
Icon in 5.25
Icon in 5.24 |
||
Created attachment 149041 [details]
Icon in 5.24
Can reproduce. Let me guess, you're using scaling on X11? Seems like the icon size doesn't actually change at all according to the panel thickness anymore. With a skinny panel, I can make it get clipped! I think didn't notice this during code review for the MR that caused this (https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/157) because by sheer coincidence, it happens to look perfect with my panel thickness (52 on Wayland with 200% scale). Ivan, could you investigate? (In reply to Nate Graham from comment #2) > Can reproduce. Let me guess, you're using scaling on X11? No, this is on Wayland. Interesting. Any scaling, or 100% scale? (In reply to Nate Graham from comment #4) > Interesting. Any scaling, or 100% scale? No scaling. Actually the icon does resize when I change the panel size. The problem it that the padding is always the same regardless of the icon size: about 10 px up and down. So I believe my original bug description was more accurate. That's interesting. It doesn't scale at all for me. I wonder why we see different things. Hiii. Yes, I refactored that applet recently, and I gotta admit that the icon sizing code is… not really what we'd want to see in production, especially the compact representation. The refactoring has fixed a bunch of problems on it own, but sizing didn't get much better because of it. Also, I don't really remember which kind of scaling am I using, and I can't reasonably run Wayland on NVIDIA. With thag being said, I have a half-baked patch attempting to fix the layout, but likely I'll end up rewriting to some existing delegate component, or even a menu. > That's interesting. It doesn't scale at all for me. I wonder why we see different things.
Nate, we all know you love certical panels :) And that's a whole different story for this particular applet.
Vertical panels strike again! A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/240 Git commit 3971511170015b83b2c18d6bbdf3d211e46142c6 by Nate Graham, on behalf of Antonio Rojas. Committed on 03/10/2022 at 08:00. Pushed by ngraham into branch 'master'. User switcher: fix excessive vertical padding in horizontal panels This value brings it approximately on par with the other panel applets. FIXED-IN: 5.26 M +1 -1 applets/userswitcher/package/contents/ui/main.qml https://invent.kde.org/plasma/kdeplasma-addons/commit/3971511170015b83b2c18d6bbdf3d211e46142c6 Git commit edef412e0ce0406502b0c21f9d01ff1c7e4d8bca by Nate Graham, on behalf of Antonio Rojas. Committed on 03/10/2022 at 08:01. Pushed by ngraham into branch 'Plasma/5.26'. User switcher: fix excessive vertical padding in horizontal panels This value brings it approximately on par with the other panel applets. FIXED-IN: 5.26 (cherry picked from commit 3971511170015b83b2c18d6bbdf3d211e46142c6) M +1 -1 applets/userswitcher/package/contents/ui/main.qml https://invent.kde.org/plasma/kdeplasma-addons/commit/edef412e0ce0406502b0c21f9d01ff1c7e4d8bca |
Created attachment 149040 [details] Icon in 5.25 In 5.25, the icon rendering has changed and there is too much padding around it, making the icon excessively small