Bug 454102

Summary: Screen corners can't trigger new Desktop Grid Effect on Plasma 5.25 beta
Product: [Plasma] kwin Reporter: Patrick Silva <bugseforuns>
Component: effects-desktop-gridAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: jr, nate, notmart
Priority: NOR Keywords: regression
Version: 5.24.90   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 5.25
Sentry Crash Report:

Description Patrick Silva 2022-05-20 17:57:01 UTC
SUMMARY
When I set desktop grid effect to a screen corner/edge in Screen Edges KCM and try to trigger it, nothing happens. When I press ctrl+f8 (default shortcut for desktop grid effect), the old desktop effect is triggered.

EXPECTED RESULT
the new desktop grid effect should work

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.24.90
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4
Graphics Platform: Wayland
Comment 1 Patrick Silva 2022-05-20 18:16:07 UTC
Same on X11.
Comment 2 Nate Graham 2022-05-23 17:02:49 UTC
This sounds like a packaging bug, as the code for the old effect was fully removed in KWin's source code repo. Can you follow up with the Arch folks about it?
Comment 3 Patrick Silva 2022-05-23 17:13:53 UTC
I don't think so. I have the same problem on neon unstable.
Comment 4 Nate Graham 2022-05-23 17:16:39 UTC
I'm at a loss, then. It's working for me. CCing Jonathan, the Plasma release manager. Maybe there's some issue with the tarballs or something?
Comment 5 Patrick Silva 2022-05-23 17:39:27 UTC
I have seen a screenshot in Vlad's blog, the new effect is almost identical to the old one.
https://blog.vladzahorodnii.com/2022/05/09/whats-cooking-in-kwin-plasma-5-25/

Now I think I'm seeing the new effect on my systems, but it is not triggered via screen edges/corners.
Comment 6 Nate Graham 2022-05-23 17:57:18 UTC
Ok cool.

I had an issue early in the review process with the default top-left screen corner not working, but that is working for me now. Does it work if you re-assign it to any other screen corner?

Does it wok if you click the "Defaults" button and then Apply?

Does it work if you reset the top-left screen corner to do nothing, and then make it do "Present Windows - All Desktops"?
Comment 7 Patrick Silva 2022-05-23 18:01:47 UTC
Tried all corners and edges on neon unstable, none works.
Comment 8 Patrick Silva 2022-05-23 18:05:06 UTC
(In reply to Nate Graham from comment #6)
> Ok cool.
> 
> I had an issue early in the review process with the default top-left screen
> corner not working, but that is working for me now. Does it work if you
> re-assign it to any other screen corner?
no.

> Does it wok if you click the "Defaults" button and then Apply?
no.

> Does it work if you reset the top-left screen corner to do nothing, and then
> make it do "Present Windows - All Desktops"?
no.
Comment 9 Nate Graham 2022-05-23 19:18:10 UTC
That's odd.

Do any screen corners work for the Present Windows effect? Is that broken too? Or is only the Desktop Grid broken in screen corner activation?

When you set one of these effects in the KCM and move your cursor into the appropriate corner, do you see the glow effect, or not?
Comment 10 Patrick Silva 2022-05-24 01:44:26 UTC
Tested all actions with upper left corner. Desktop Grid always fails and 'Toggle window switching' fails with the steps below.
When the chosen action fails, I don't see the glow effect.

To reproduce the bug with 'Toggle window switching' action:
1. choose 'Toggle alternative window switching' action and apply
2. now choose 'Toggle window switching' action and apply
3. try to trigger the chosen action
Comment 11 Nate Graham 2022-05-24 15:24:26 UTC
I can reproduce the Desktop Grid effect not working from any screen corners or edges. I thought we were talking about Present Windows earlier, sorry.
Comment 12 Bug Janitor Service 2022-05-25 08:28:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2464
Comment 13 Nate Graham 2022-05-25 18:29:17 UTC
Git commit 486d229caefa83c90198204ae62b44149a89132d by Nate Graham, on behalf of Vlad Zahorodnii.
Committed on 25/05/2022 at 18:11.
Pushed by ngraham into branch 'master'.

effects/desktopgrid: Fix config group name

The config group is formed as "Effect-" + plugin id, i.e. "desktopgrid"

Config migration from DesktopGrid to desktopgrid is already handled by
a kconf_update script.
Part-of: <https://invent.kde.org/plasma/kwin/-/merge_requests/2464>

M  +1    -1    src/effects/desktopgrid/desktopgridconfig.kcfg

https://invent.kde.org/plasma/kwin/commit/486d229caefa83c90198204ae62b44149a89132d
Comment 14 Nate Graham 2022-05-25 18:29:49 UTC
Git commit 4c4cb446788269df0b8f1fcba15431d4ca33a146 by Nate Graham, on behalf of Vlad Zahorodnii.
Committed on 25/05/2022 at 18:29.
Pushed by ngraham into branch 'Plasma/5.25'.

effects/desktopgrid: Fix config group name

The config group is formed as "Effect-" + plugin id, i.e. "desktopgrid"

Config migration from DesktopGrid to desktopgrid is already handled by
a kconf_update script.
Part-of: <https://invent.kde.org/plasma/kwin/-/merge_requests/2464>


(cherry picked from commit 486d229caefa83c90198204ae62b44149a89132d)

M  +1    -1    src/effects/desktopgrid/desktopgridconfig.kcfg

https://invent.kde.org/plasma/kwin/commit/4c4cb446788269df0b8f1fcba15431d4ca33a146