Bug 454018

Summary: booking.com holiday home not recognized
Product: [Applications] KDE Itinerary Reporter: Gerion <gerion.entrup>
Component: generalAssignee: Volker Krause <vkrause>
Status: REPORTED ---    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Android   
OS: Android 10.x   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Gerion 2022-05-18 23:11:49 UTC 
SUMMARY
I just booked a holiday home at booking.com, but I'm not able to import the booking into my Itinerary app.
What I tried so far:

- Scan the QR code in the e-mail, which they use to make you install the app: https://www.booking.com/apps.html?app_install=1&lang=en&etseed=52... (not very likely to contain the actual reservation data but the first QR code that I saw). My qr-code reader app also offers to send this link to Itinerary but nothing happens.
- Copy the link to the booking.com manage site (where you can see and manage your booking) and select "Paste" in Itinerary. Itinerary shows: "Nothing imported". The link has the format: https://secure.booking.com/myreservations.en-us.html?aid=30xxxxx;bn%3D2xxxxxxxxx;pincode%3Dxxxxx


SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
kitinerary version: 21.12.3
Qt Version: 5.15.2

On the android app:
Application version: 22.07.70 (76eb203)
Engine version: 5.20.41

ADDITIONAL INFORMATION

My KMail does not show a special header for the booking.com e-mail. I should have installed all neccessary packages, at least kitinerary is installed (https://packages.gentoo.org/packages/kde-apps/kitinerary).

I'm pretty sure that Itinerary should support booking.com since I searched the source code on Github and found some test cases for it. Can I see the supported extractors somewhere in the app? Is there some kind of documentation what input is expected for a specific extractor?
Comment 1 Volker Krause 2022-05-20 15:38:38 UTC 
If KMail isn't able to detect it then this is likely a variant of their emails that isn't supported yet, or that contains some variation that the extractor doesn't expect (unusual characters in the hotel name or address for example). The app uses the same extractor, so it wont be able to get anything out of this either then.

In general there are two ways to extract this data: standardized formats like machine-readable schema.org JSON or Microdata annotations in the email, or custom extractor scripts specific for a certain provider or booking software vendor. booking.com is a bit special, they have both. Some of their emails have machine-readable annotations, some are extracted with a custom script. Where this fails in your case needs to be investigated with the specific email I guess.
Comment 2 Gerion 2022-05-20 22:41:35 UTC 
(In reply to Volker Krause from comment #1)
> Where this fails in your case needs to be investigated with the
> specific email I guess.

How can I help you with that (I'm able to use a debugger :))?
Comment 3 Volker Krause 2022-05-22 08:05:45 UTC 
(In reply to ci3nte from comment #2)
> How can I help you with that (I'm able to use a debugger :))?

The best way for this would probably be opening the email in "KItinerary Workbench" (if not available as a distro package, there are for example nightly Flatpak builds by KDE), and see if that shows extractor script errors.