Bug 453940

Summary:	Launch feedback on cursor inappropriately displayed when KRunner is shown and hidden
Product:	[Plasma] krunner	Reporter:	Nate Graham <nate>
Component:	general	Assignee:	Alexander Lohnau <alexander.lohnau>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, bugseforuns, plasma-bugs-null
Priority:	NOR	Keywords:	regression
Version First Reported In:	master
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=453906
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/675e5ada45190d616eeff3cb29db386b76c23a73	Version Fixed/Implemented In:	5.25
Sentry Crash Report:

Description Nate Graham 2022-05-17 15:10:08 UTC

Showing KRunner with Alt+Space or Alt+F2 causes the launch feedback animation to play on my cursor for a moment

Hiding it again with the same shortcut causes the launch feedback animation to play until it hits the timeout (5 seconds, by default).

This is a recent regression in git master; I just noticed it today and don't think it was happening last week. Maybe something to do with the recent xdg activation protocol work?

Comment 1 Aleix Pol 2022-05-17 15:44:25 UTC

It's probably that you have the kglobalaccel activation MR support built?

It's the activation that makes this bouncing thing show. I see it's the generic icon because krunner doesn't have a desktop file, maybe we just shouldn't notify when it's unknown.

Comment 2 Nate Graham 2022-05-17 16:51:04 UTC

> It's probably that you have the kglobalaccel activation MR support built?
Ah, right you are! Should we close this bug report?

> maybe we just shouldn't notify when it's unknown.
Yeah that might be better.

Comment 3 Bug Janitor Service 2022-05-17 17:17:37 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2415

Comment 4 Nate Graham 2022-05-17 17:20:33 UTC

*** Bug 453906 has been marked as a duplicate of this bug. ***

Comment 5 Vlad Zahorodnii 2022-05-24 14:41:04 UTC

Git commit 675e5ada45190d616eeff3cb29db386b76c23a73 by Vlad Zahorodnii, on behalf of Aleix Pol.
Committed on 24/05/2022 at 14:40.
Pushed by vladz into branch 'Plasma/5.25'.

xdg_activation_v1: Do not bounce icon if the desktop file was not found

It's annoying and doesn't buy us much.
Additionally, take X-KDE-StartupNotify into account as we are meant to.
Tested-by: Merge Service <https://invent.kde.org/plasma/kwin/-/merge_requests/2415>
Part-of: <https://invent.kde.org/plasma/kwin/-/merge_requests/2415>


(cherry picked from commit cad5ddbab33edb64f599b49b4d6ef263a88676e7)

M  +13   -7    src/window.cpp
M  +2    -0    src/window.h
M  +11   -3    src/xdgactivationv1.cpp
M  +4    -3    src/xdgactivationv1.h

https://invent.kde.org/plasma/kwin/commit/675e5ada45190d616eeff3cb29db386b76c23a73