Bug 453922

Summary:	Decimal and thousands separators in ordinate axis labels are missing
Product:	[Applications] kmymoney	Reporter:	Thomas Baumgart <tbaumgart>
Component:	reports	Assignee:	KMyMoney Devel Mailing List <kmymoney-devel>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/office/kmymoney/commit/2226d483f819dbee0036e4a84ac66509ca706203	Version Fixed In:	5.1.3
Sentry Crash Report:

Description Thomas Baumgart 2022-05-17 05:50:22 UTC

Source of this request: https://forum.kde.org/viewtopic.php?f=69&t=174795 (though it bugs me too every now and then)

STEPS TO REPRODUCE
1. Open networth report (with networth > 1000)

OBSERVED RESULT
Labels on y-axis do not contain thousand separator and are hard to read (e.g. 1000000). The same is valid for labels on the graph and tooltips.

EXPECTED RESULT
All values are displayed with thousand separators for better readability (e.g. 1.000.000 or 1,000,000 depending on the actual character used in the locale). Removing trailing decimal separator with only zeroes following is valid.

ADDITIONAL INFORMATION
Comment in current implementation contains the following comment:

    // convert label to double just to convert it back to string with desired precision
    // but without trailing zeros, separator, or decimal point

which was added with https://invent.kde.org/office/kmymoney/-/commit/5e4c8322 which fixes bug #420767

Comment 1 Thomas Baumgart 2022-05-17 05:55:53 UTC

Git commit cbf8ad93429055d8b4059f0212b2afed687b7441 by Thomas Baumgart.
Committed on 17/05/2022 at 05:55.
Pushed by tbaumgart into branch 'master'.

Format monetary values in graphs to contain separators

M  +6    -10   kmymoney/plugins/views/reports/core/kreportcartesianaxis.cpp
M  +20   -5    kmymoney/plugins/views/reports/core/kreportchartview.cpp

https://invent.kde.org/office/kmymoney/commit/cbf8ad93429055d8b4059f0212b2afed687b7441

Comment 2 Thomas Baumgart 2022-05-17 06:00:43 UTC

Git commit 2226d483f819dbee0036e4a84ac66509ca706203 by Thomas Baumgart.
Committed on 17/05/2022 at 06:00.
Pushed by tbaumgart into branch '5.1'.

Format monetary values in graphs to contain separators
FIXED-IN: 5.1.3

(cherry picked from commit cbf8ad93429055d8b4059f0212b2afed687b7441)

M  +7    -11   kmymoney/plugins/views/reports/core/kreportcartesianaxis.cpp
M  +20   -5    kmymoney/plugins/views/reports/core/kreportchartview.cpp

https://invent.kde.org/office/kmymoney/commit/2226d483f819dbee0036e4a84ac66509ca706203