| Summary: | Allow configuring the applet to use more than one dictionary, but not all of them | ||
|---|---|---|---|
| Product: | [Plasma] kdeplasma-addons | Reporter: | Gergely HORVÁTH <horvathg.1988> |
| Component: | dictionary | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bjorn.bidar, kdelibs-bugs, nate, nicolas.fella, qydwhotmail |
| Priority: | NOR | ||
| Version: | 5.24.5 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/commit/be5f636c0baa63de4981b89b6970ba02fe2abb87 | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
|
Description
Gergely HORVÁTH
2022-05-16 09:55:50 UTC
Seems reasonable. Looks possible by using command pipelining. https://datatracker.ietf.org/doc/html/rfc2229#section-4 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/159 Git commit bc8d35bae6d8f67bda734261a84ef4488b2738a7 by Fushan Wen. Committed on 25/05/2022 at 15:29. Pushed by fusionfuture into branch 'master'. dict: don't early return when no definition is found We don't want to abort loading when one dict returns no definition. M +3 -2 dict/dictengine.cpp M +1 -1 dict/dictengine.h https://invent.kde.org/plasma/kdeplasma-addons/commit/bc8d35bae6d8f67bda734261a84ef4488b2738a7 Git commit 04773128a2d268a79ca9274cb2bd3d56afc03591 by Fushan Wen. Committed on 25/05/2022 at 15:29. Pushed by fusionfuture into branch 'master'. dict: support multiple dicts in the engine The dict protocol supports "Command Pipelining", so the engine can concatenate multiple DEFINE commands into one command. See also: https://datatracker.ietf.org/doc/html/rfc2229#section-4 M +11 -7 dict/dictengine.cpp M +2 -2 dict/dictengine.h https://invent.kde.org/plasma/kdeplasma-addons/commit/04773128a2d268a79ca9274cb2bd3d56afc03591 Git commit be5f636c0baa63de4981b89b6970ba02fe2abb87 by Fushan Wen. Committed on 26/05/2022 at 01:06. Pushed by fusionfuture into branch 'master'. applets/dict: support multiple dictionaries in the config dialog Multiple dictionaries are saved in a string, split with comma ",". FIXED-IN: 5.26 A +77 -0 applets/dict/package/contents/ui/AvailableDictSheet.qml [License: GPL(v2.0+)] M +76 -42 applets/dict/package/contents/ui/ConfigDictionaries.qml A +59 -0 applets/dict/package/contents/ui/DictItemDelegate.qml [License: GPL(v2.0+)] https://invent.kde.org/plasma/kdeplasma-addons/commit/be5f636c0baa63de4981b89b6970ba02fe2abb87 Git commit 988bcc37b008a8cb4cecbdb18fa985417f1a7aec by Fushan Wen. Committed on 25/05/2022 at 15:56. Pushed by fusionfuture into branch 'master'. applets/dict: add EnabledDictModel to show enabled dictionaries The model will be initialized after the dict list is fetched. M +2 -0 applets/dict/plugin/dict_plugin.cpp M +230 -1 applets/dict/plugin/dictionariesmodel.cpp M +51 -4 applets/dict/plugin/dictionariesmodel.h https://invent.kde.org/plasma/kdeplasma-addons/commit/988bcc37b008a8cb4cecbdb18fa985417f1a7aec Thank you for solving it! How can I test the code? I have kdesrc build already setup, I intendt to compile it and run until 5.26 hits the Arch repos. To have the same functionality in the equivalent Krunner are there other changes needed? |