Bug 453866

Summary:	When a brush is assigned to "My favourites" the category still appears in the "Assign to tag" menu
Product:	[Applications] krita	Reporter:	Hologram <intuos5>
Component:	Resource Management	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED WAITINGFORINFO
Severity:	minor	CC:	halla
Priority:	NOR
Version First Reported In:	5.0.6
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Hologram 2022-05-16 05:44:05 UTC

SUMMARY
***
When a brush is assigned to "My favourites" the category still appears in the "Assign to tag" menu. This can be confusing, because it may prompt one to reassign a brush to my favourites.
***


STEPS TO REPRODUCE
1. Open the brush preset docker 
2. Right click the brush and assign a random brush to the "My favourites" category
3. Right click the brush again and go to the "assign to tag" menu once again. 
4. Notice the category "My favourites" still appears



OBSERVED RESULT
4. Notice the category "My favourites" still appears

EXPECTED RESULT
Just like any other category, the category should disappear from the "Assign to tag" menu if the brush is already assigned to this tag. 

SOFTWARE/OS VERSIONS
Windows: 10
Qt Version: 5.12.12

Comment 1 Halla Rempt 2022-07-13 09:00:26 UTC

I cannot reproduce this with 5.1 beta 1. I've tried on Windows and Linux, with application language set to default US English and to French. Can you still reproduce this?

Comment 2 Hologram 2022-07-17 14:23:39 UTC

I'm also no longer able to reproduce it as of 5.1 Beta 1. It could have been caused by the 5.0 Beta days, which prompted me to delete the .sqlite database for brushes. So it's unlikely to be an issue in the future either.