Summary: | file size display: please follow BinaryUnitDialect everywhere | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Erik Quaeghebeur <bugs.kde.org> |
Component: | view-engine: general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jackhill3103, karl, kfm-devel, nate, vmelkon |
Priority: | NOR | ||
Version: | 21.12.3 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=364321 | ||
Latest Commit: | https://invent.kde.org/frameworks/kcoreaddons/-/commit/58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10 | Version Fixed In: | Frameworks 6.0 |
Bug Depends on: | 57240 | ||
Bug Blocks: |
Description
Erik Quaeghebeur
2022-05-15 20:27:57 UTC
I have tested this on Kubuntu 22.04 I can confirm that I have the same result. KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.92.0 Qt Version: 5.15.3 I have tried BinaryUnitDialect=2 and BinaryUnitDialect=1. If I have no file selected, on the Status bar it shows 68 folder, 6 files (6.4 MiB). It is showing MiB instead of MB. This also applies to displaying file sizes in the settings dialog, e.g., for the ‘Skip previews for local files above:’ setting (‘General’ category). Here (file settings/general/previewssettingspage.cpp) the value is hardcoded using the (translatable) string ‘MiB’. I verified it on Kubuntu 22.04. In the configure - Dolphin dialog box, On the left side, select General. On the right side, select the Preview tab. At the bottom, Skip previews for local files above, the units are always in MiB This also effects System Monitor. It always shows RAM usage and network activity as KiB and MiB and GiB. There doesn’t seem to be a way to configure it. *** Bug 472112 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/572 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/352 Git commit 58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10 by Jack Hill. Committed on 12/07/2023 at 17:01. Pushed by cullmann into branch 'master'. Use BinaryUnitDialect from config when using DefaultBinaryDialect in formatByteSize Still fall back to IECBinaryDialect if the value isn't set, or isn't set properly. Related: bug 472111 M +8 -2 src/lib/util/kformatprivate.cpp https://invent.kde.org/frameworks/kcoreaddons/-/commit/58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10 |