Bug 453847

Summary: "Save New Brush Preset" or "Overwrite Brush Preset" causes the current window to lock.
Product: [Applications] krita Reporter: thalia.adkins.covert
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: amy, halla
Priority: NOR Keywords: triaged
Version: 5.0.6   
Target Milestone: ---   
Platform: macOS (DMG)   
OS: macOS   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: attachment-5019-0.html
attachment-10066-0.html
attachment-22172-0.html

Description thalia.adkins.covert 2022-05-15 19:14:55 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Open Krita, either creating a new canvas or opening an existing one.
2. Open the Brush Editor.
3. Select either "Save New Brush Preset" or "Overwrite Brush Preset."

OBSERVED RESULT
The brush editor window locks and makes all buttons within it unclickable. This is only solved by quitting the program. This is not observed in current builds of Windows versions.

EXPECTED RESULT
A window usually pops up asking for the name of the new brush to be saved and an icon to be selected for the preset.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2022-08-09 12:43:41 UTC
I cannot reproduce this with either 5.0.6 or with 5.1.0-RC1 on macOS. The brush editor window is hidden, the brush saving dialog pops up, and it just works here.
Comment 2 Halla Rempt 2022-08-11 08:55:44 UTC
If you can still reproduce this, I will need a screen recording or something like that to see what might be up.
Comment 3 thalia.adkins.covert 2022-08-12 19:40:37 UTC
Hello Halla Rempt,

Attached is a screen recording showing the issue.

As shown in the recording, when "Save New Brush Preset" was clicked, the
window locked. Pressing the button in the upper-left corner to close did
nothing, and the scratchpad function was not working. Luckily, due to a
recent update, clicking away from the current window and hitting the Escape
key on my keyboard now unlocks the window. I can then close out and
continue working without having to reset the program. The brush does not
save, however.

Please let me know if there is a way to fix this, I hope the screen
recording helps. Thank you for your time, I appreciate your help!

Thank you so much,
Thalia Adkins-Covert

On Thu, Aug 11, 2022, 3:55 AM Halla Rempt <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=453847
>
> Halla Rempt <halla@valdyas.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>          Resolution|---                         |WAITINGFORINFO
>              Status|REPORTED                    |NEEDSINFO
>
> --- Comment #2 from Halla Rempt <halla@valdyas.org> ---
> If you can still reproduce this, I will need a screen recording or
> something
> like that to see what might be up.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 4 thalia.adkins.covert 2022-08-13 00:54:23 UTC
Created attachment 151295 [details]
attachment-5019-0.html

I apologize. I just got an announcement that the attachment was too large.
Here is a link to the screen recording.
https://drive.google.com/file/d/1UqqBU2K8tgal55bg9GZX4ZXRSsxo79oG/view?usp=sharing


On Fri, Aug 12, 2022 at 2:39 PM Thalia Adkins-Covert <
thalia.adkins.covert@gmail.com> wrote:

> Hello Halla Rempt,
>
> Attached is a screen recording showing the issue.
>
> As shown in the recording, when "Save New Brush Preset" was clicked, the
> window locked. Pressing the button in the upper-left corner to close did
> nothing, and the scratchpad function was not working. Luckily, due to a
> recent update, clicking away from the current window and hitting the Escape
> key on my keyboard now unlocks the window. I can then close out and
> continue working without having to reset the program. The brush does not
> save, however.
>
> Please let me know if there is a way to fix this, I hope the screen
> recording helps. Thank you for your time, I appreciate your help!
>
> Thank you so much,
> Thalia Adkins-Covert
>
> On Thu, Aug 11, 2022, 3:55 AM Halla Rempt <bugzilla_noreply@kde.org>
> wrote:
>
>> https://bugs.kde.org/show_bug.cgi?id=453847
>>
>> Halla Rempt <halla@valdyas.org> changed:
>>
>>            What    |Removed                     |Added
>>
>> ----------------------------------------------------------------------------
>>          Resolution|---                         |WAITINGFORINFO
>>              Status|REPORTED                    |NEEDSINFO
>>
>> --- Comment #2 from Halla Rempt <halla@valdyas.org> ---
>> If you can still reproduce this, I will need a screen recording or
>> something
>> like that to see what might be up.
>>
>> --
>> You are receiving this mail because:
>> You reported the bug.
>
>
Comment 5 Bug Janitor Service 2022-08-13 04:35:38 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 6 Halla Rempt 2022-08-13 16:31:09 UTC
It looks like somehow on your system the brush save dialog is either shown behind the brush editor dialog. On my mac it replaces the brush editor dialog. I'm using Rectangle, though, so that might have some influence. Do you use any window management utitilies apart from what apple provides?
Comment 7 thalia.adkins.covert 2022-08-14 13:33:15 UTC
Created attachment 151318 [details]
attachment-10066-0.html

Not that I am aware of, no.

On Sat, Aug 13, 2022, 11:31 AM Halla Rempt <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=453847
>
> --- Comment #6 from Halla Rempt <halla@valdyas.org> ---
> It looks like somehow on your system the brush save dialog is either shown
> behind the brush editor dialog. On my mac it replaces the brush editor
> dialog.
> I'm using Rectangle, though, so that might have some influence. Do you use
> any
> window management utitilies apart from what apple provides?
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 8 amyspark 2022-08-14 17:14:47 UTC
On the last master build I have here, macOS Big Sur 11.6.8 and 5.2.0-prealpha 2b1c570, the dialog is classified as a NSSheet (borderless dialog, blocks the owner window).  That's why escaping it works.

I do see, though, that the save dialog is parented to the main Krita app but *not* to the brush editor. That one's shown separately from Krita.
Comment 9 thalia.adkins.covert 2022-08-14 21:54:48 UTC
Created attachment 151327 [details]
attachment-22172-0.html

I tried the most recent build (Build #782) and the issue is fixed. Thank
you!

On Sun, Aug 14, 2022 at 12:14 PM amyspark <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=453847
>
> amyspark <amy@amyspark.me> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |amy@amyspark.me
>
> --- Comment #8 from amyspark <amy@amyspark.me> ---
> On the last master build I have here, macOS Big Sur 11.6.8 and
> 5.2.0-prealpha
> 2b1c570, the dialog is classified as a NSSheet (borderless dialog, blocks
> the
> owner window).  That's why escaping it works.
>
> I do see, though, that the save dialog is parented to the main Krita app
> but
> *not* to the brush editor. That one's shown separately from Krita.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 10 Halla Rempt 2022-08-15 07:41:40 UTC
thanks for checking