Bug 453651

Summary:	A page from KDE Store removed via 'Edit or remove pages...' is still marked as installed on the GHNS view until the app is restarted
Product:	[Applications] plasma-systemmonitor	Reporter:	Patrick Silva <bugseforuns>
Component:	general	Assignee:	KSysGuard Developers <ksysguard-bugs>
Status:	CONFIRMED ---
Severity:	normal	CC:	ahiemstra, kde, nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.25.90
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-systemmonitor/commit/3c6c09e3b0b218e5364a1c87d6ba3e1b6cb7eee0	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	video recorded on neon unstable

Description Patrick Silva 2022-05-11 11:27:10 UTC

STEPS TO REPRODUCE
1. open System Monitor
2. click on hamburger button and choose 'Get new pages...'
3. install any page(s) (I installed Load Overview and Network Status)
4. click on hamburger button and choose 'Edit or remove pages...'
5. remove the page(s) installed in the step 3 and click on 'OK' button
6. click on hamburger button and choose 'Get new pages...'

OBSERVED RESULT
the page(s) removed in the step 5 are still marked as installed in 'Get new pages'

EXPECTED RESULT
a page removed via 'Edit or remove pages...' should not be marked as installed in 'Get new pages'

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Graphics Platform: Wayland

Comment 1 Ben Cooksley 2023-01-27 06:25:39 UTC

Git commit 14f82d354704406a256050bf384546e7073389de by Ben Cooksley, on behalf of Arjen Hiemstra.
Committed on 27/01/2023 at 06:24.
Pushed by bcooksley into branch 'master'.

Set RemoveDeadEntries=true in the pages knsrc

Otherwise pages removed from the "add/remove pages" dialog will remain
marked as installed while no longer installed.

M  +1    -0    src/plasma-systemmonitor.knsrc

https://invent.kde.org/plasma/plasma-systemmonitor/commit/14f82d354704406a256050bf384546e7073389de

Comment 2 Ben Cooksley 2023-01-27 20:00:38 UTC

Git commit 3c6c09e3b0b218e5364a1c87d6ba3e1b6cb7eee0 by Ben Cooksley, on behalf of Arjen Hiemstra.
Committed on 27/01/2023 at 20:00.
Pushed by bcooksley into branch 'Plasma/5.27'.

Set RemoveDeadEntries=true in the pages knsrc

Otherwise pages removed from the "add/remove pages" dialog will remain
marked as installed while no longer installed.
(cherry picked from commit 14f82d354704406a256050bf384546e7073389de)

M  +1    -0    src/plasma-systemmonitor.knsrc

https://invent.kde.org/plasma/plasma-systemmonitor/commit/3c6c09e3b0b218e5364a1c87d6ba3e1b6cb7eee0

Comment 3 Patrick Silva 2023-02-15 19:05:44 UTC

It's still reproducible.

Operating System: Arch Linux 
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Graphics Platform: Wayland

Comment 4 Nate Graham 2023-02-16 23:05:02 UTC

Cannot reproduce. Can you verify that /usr/share/knsrcfiles/plasma-systemmonitor.knsrc has "RemoveDeadEntries=true" in it?

If it does, can you attach a screen recording that shows the issue happening?

Comment 5 Patrick Silva 2023-02-16 23:35:07 UTC

Created attachment 156334 [details]
video recorded on neon unstable

(In reply to Nate Graham from comment #4)
> Cannot reproduce. Can you verify that
> /usr/share/knsrcfiles/plasma-systemmonitor.knsrc has
> "RemoveDeadEntries=true" in it?
> 
> If it does, can you attach a screen recording that shows the issue happening?

I'm using neon unstable now, can reproduce on it too.
Can confirm /usr/share/knsrcfiles/plasma-systemmonitor.knsrc has "RemoveDeadEntries=true" in it.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Graphics Platform: X11

Comment 6 Nate Graham 2023-02-17 18:06:22 UTC

Ahh, they're still marked as present in the GHNS page. Can reproduce that. But restarting the app fixes it. So it looks like it's just not getting notified properly.