Bug 453617

Summary:	Add "Ignore face" button for unrecongised faces in thumbnail view
Product:	[Applications] digikam	Reporter:	arthur
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	7.7.0
Target Milestone:	---
Platform:	macOS (DMG)
OS:	macOS
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/c0e76980c714b4a7b4e61dd735e798c3b628d2e6	Version Fixed In:	7.7.0
Sentry Crash Report:

Description arthur 2022-05-10 09:12:48 UTC

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
When tagging faces it would be useful to be able to tag unknown/unrecognised faces as ignored instead of only being able to remove them. This would make tagging new faces more efficient after a complete library rescan (so the unknown faces don't pop up again as such, and instead remain ignored).

STEPS TO REPRODUCE
Not relevant

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Maik Qualmann 2022-05-10 11:48:35 UTC

The ignore function is available for unknown and unconfirmed faces. What might cause you a problem are 2 different icons for ignore.
Or do I misunderstand you?

Maik

Comment 2 arthur 2022-05-10 12:12:24 UTC

I checked again, and it turns out I had been confused by the difference in the interface. In the recognised photos tab there are three buttons beneath each thumbnail
* confirm the suggestion (which is a checkmark)
* reject the suggestion (which is a minus sign)
* ignore the face altogether (which is a backwards pointing arrow)

In the unknown faces menu there are three buttons
* confirm the name you write yourself (which is a checkmark)
* ignore the face altogether (which is a minus sign)

I got confused because the same button (the minus sign) is used for two different functions in very similar contexts. So my original request was null, but it would be nice for the "ignore" button on the unknown faces menu to be changes to the backwards pointing arrow so it's in line with the functions in the suggested faces menu.

Comment 3 Maik Qualmann 2022-05-10 12:23:03 UTC

Thanks for the feedback. I confirm the problem with the different icons and it will be fixed.

Maik

Comment 4 Maik Qualmann 2022-05-13 19:57:33 UTC

Git commit c0e76980c714b4a7b4e61dd735e798c3b628d2e6 by Maik Qualmann.
Committed on 13/05/2022 at 19:56.
Pushed by mqualmann into branch 'qt5-maintenance'.

uniform and new icon to ignore faces
FIXED-IN: 7.7.0

M  +2    -1    NEWS
M  +3    -3    core/utilities/facemanagement/widgets/assignnamewidget.cpp
M  +4    -2    core/utilities/facemanagement/widgets/assignnamewidget_p.cpp
M  +2    -2    core/utilities/facemanagement/widgets/assignnamewidget_p.h

https://invent.kde.org/graphics/digikam/commit/c0e76980c714b4a7b4e61dd735e798c3b628d2e6