Bug 453609

Summary:	kwin commit 4cb3ab09e: build error: kwinanimationeffect.cpp:14:10 fatal error: QAction: No such file or directory:
Product:	[Plasma] kwin	Reporter:	Duncan <1i5t5.duncan>
Component:	effects-various	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	notmart
Priority:	NOR
Version First Reported In:	git master
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://invent.kde.org/plasma/kwin/commit/313baa4b510e6778656679bed67c649eb6bb95c6	Version Fixed/Implemented In:
Sentry Crash Report:

Description Duncan 2022-05-10 05:08:02 UTC

kwin commit 4cb3ab09e (thru e1cec89dd HEAD)  won't build.  The previous commit (46bbe4ff0) builds fine.  The error is:

src/libkwineffects/kwinanimationeffect.cpp:14:10: fatal error: QAction: No such file or directory
14 | #include <QAction>

I'm on git master for kde-frameworks/-plasma/(most)-gear, using the live-git ebuilds from the gentoo/kde overlay and /usr/include/qt5/QtWidgets/QAction (and qaction.h) exist.

Missed dep in CMakeLists.txt?  (Not investigated yet.)

 (I should also mention, actually here the canonical location is /include/... as I'm running reverse-usrmerge, with a /usr symlink: /usr -> .   But it's normally all found just fine, and other qt libs are found in this case, but not that one.)

Comment 1 Duncan 2022-05-10 06:37:03 UTC

(In reply to Duncan from comment #0)
> Missed dep in CMakeLists.txt?  (Not investigated yet.)

Indeed.  But while I already have it and might as well post it, I'm not dev-side-git familiar enough for a PR to be an option and patchfiles submitted here seem to be studiously ignored (to be fair the warning says as much, but that doesn't help people who don't know how to do a PR but already have the patch from troubleshooting the problem and might as well post it), so we'll see if posting it as text is as studiously ignored as patchfiles seem to be. <shrug>

--- a/src/libkwineffects/CMakeLists.txt 2022-05-09 21:26:13.964236519 -0700
+++ b/src/libkwineffects/CMakeLists.txt 2022-05-09 22:21:46.805839417 -0700
@@ -55,6 +55,7 @@ target_link_libraries(kwineffects
         KF5::WindowSystem
         XCB::XCB
     PRIVATE
+        Qt::Widgets
         Qt::Quick
         KF5::I18n
          kwinglutils

Comment 2 Vlad Zahorodnii 2022-05-10 10:36:26 UTC

Git commit 313baa4b510e6778656679bed67c649eb6bb95c6 by Vlad Zahorodnii.
Committed on 10/05/2022 at 10:14.
Pushed by vladz into branch 'master'.

Remove QAction include in AnimationEffect

It builds fine without QAction include.

M  +0    -1    src/libkwineffects/kwinanimationeffect.cpp

https://invent.kde.org/plasma/kwin/commit/313baa4b510e6778656679bed67c649eb6bb95c6