Bug 453587

Summary:	Menu separator items interfere with keyboard arrow keys
Product:	[Frameworks and Libraries] frameworks-qqc2-desktop-style	Reporter:	Jack Hill <jackhill3103>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	ASSIGNED ---
Severity:	minor	CC:	ahiemstra, kde, nate, noahadvs, uhhadd, xnagytibor
Priority:	NOR
Version First Reported In:	5.93.0
Target Milestone:	---
Platform:	Flatpak
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Jack Hill 2022-05-09 18:25:48 UTC

SUMMARY
The separators seem to be able to take keyboard focus when using arrow keys.

STEPS TO REPRODUCE
1. Open application menu
2. Use up & down arrow keys to navigate

OBSERVED RESULT
Some items appear to require two key presses to move to.
The separators can probably take keyboard focus.

EXPECTED RESULT
Separators should not take keyboard focus, and arrow keys should ignore them.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20220506
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 Nagy Tibor 2022-05-10 06:21:50 UTC

This affects every QML application, not just Elisa. Skipping over disabled menu items are also borked.

Comment 2 Nate Graham 2022-05-10 15:52:07 UTC

lol oops. Can confirm.

Comment 3 Nate Graham 2022-05-10 19:20:24 UTC

Hmm, we have `focusPolicy: Qt.NoFocus` set on our menu separator item, but this doesn't seem to prevent it from getting keyboard focus. I wonder if the issue is in our implementation of the ListView that underpins the Menu itself.

Comment 4 Janet Blackquill 2022-05-10 19:28:54 UTC

yeah, the listview is responsible for managing the fake "focus" of its items, not the items themselves.

Comment 5 Bug Janitor Service 2025-01-21 18:34:16 UTC

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/440