Bug 453480

Created attachment 148620 [details]
No preview at high zoom level

Created attachment 148621 [details]
Some previews at low zoom level

Same issue, but for me NEF files from Nikon doesn't generate thumbnails. In the past used to work

Can you check again with Frameworks 5.94 which will be released in a few days? If that fixes it, then this was an example of Bug 451408, which is fixed in that release.

Today I update to KDE Framework 5.94, but still no thumbnails on RAW images

OK, I guess that wasn't it.

Hi every one,

Same problem here with fujifilm raw images files (.RAF), it was working a few days/weeks ago...

Thanks

Operating System: Arch Linux
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.4
Kernel Version: 5.17.9-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-4790K CPU @ 4.00GHz
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970/PCIe/SSE2

Once generated in the Gwenview browser, thumbnails are working fine in Dolphin, and if I want big thumbnails I have to generate big thumbnails first in Gwenview.

I don't know if it can help... Thanks

I cannot confirm that opening the folder in Gwenview changes anything. The previews show up fine for me in Gwenview, but it does not affect the fact that they are not displayed in Dolphin.

Just before I tried to install libopenraw and reinstall kdegraphics-thumbnailers.... I don't know if it can help.

New raw files this morning, no thumbnails in Dolphin and once generated in the Browse section of Gwenview, it works fine again in Dolphin

Possibly a regression in thumbnail plug-in loading, as the raw thumbnailer says:

# image/x-dcraw is the subclass for all "raw" image formats, so no need to list them all
MimeType=image/x-dcraw;

Possibly this inheritance isn't checked anymore.

Please attach an example file to test this with.

Does deactivating the "Images (gIf, png...)" make the previews work?

Find an example image here: https://cloud2.rankenste.in/s/7BT3r3qCKGzWM8R (it is too large to be attached here).

Disabling image previews does indeed fix the problem, thanks for the helpful workaround.

>Disabling image previews does indeed fix the problem, thanks for the helpful workaround.

Happy to help. Then my time debugging this came up with actually useful results :D

Regarding the root cause: my guess is that the raw thumbnailer provides a mimetype that we search for by the parent mime types (which works). However, the thumbnailer I asked you to disable has "image/*" as a mimetype. Meaning it says that it can consume any image.

A solution would be to process the parent mimetypes first, before evaluating the wildcards. Though it will need some though regarding potential sideeffects.

>Find an example image here

Thanks!

Its works for me too...

Thanks

This is a regression from https://invent.kde.org/network/kio-extras/-/commit/667f8dd3ee884192602a92429f5fe10f9259303d.
I would suggest reverting that in the release branches, but not in master.

For KIO, I will make a MR to resolve the parent mime types first and then handle the wildcards.

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/857

Git commit 871a3310997badd5f944f851622c04094c7b152c by Alexander Lohnau.
Committed on 31/05/2022 at 16:01.
Pushed by alex into branch 'master'.

PreviewJob: Resolve parent mime types before checking wildcards

If we have a thumbnailer with a wildcard and the mime type does not exactly match, we would
very likely ignore the parent mime type checks and use the thumbnailer with the wildcard.

In case of the raw-thumbnailer, only the parent mime type of all raw images is registered.
But with the change of the imagethumbnailer to have a wildcard-mimetype, we never call it.

Considering that the wildcards should be used as a fallback, checking it last is reasonable anyways.

M  +14   -15   src/widgets/previewjob.cpp

https://invent.kde.org/frameworks/kio/commit/871a3310997badd5f944f851622c04094c7b152c

Trying this with the following version:
Linux: 5.18.7-arch1-1
KDE Plasma Version: 5.25.2
KDE Frameworks Version: 5.95.0
Qt Version: 5.15.5

The workaround to disable image previews no longer works. Raw file previews still don't work (except for files where the preview is still cached from the workaround).

Could you provide an example file having the issue?

The problem happens for me for all raw files, including the one that I previously linked: https://cloud2.rankenste.in/s/7BT3r3qCKGzWM8R

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/901

Git commit 5002a07e71ff270a8717911b965a75c33993f883 by Alexander Lohnau.
Committed on 08/07/2022 at 09:02.
Pushed by alex into branch 'master'.

Fix thumbnailer result for parent mime types being overwritten

M  +7    -5    src/widgets/previewjob.cpp

https://invent.kde.org/frameworks/kio/commit/5002a07e71ff270a8717911b965a75c33993f883

Hi, always the same problem for me in Dolphin and now the thumbnails generation in Gwenview doesn't fix the issue...

This bug is listed as fixed in Frameworks 5.97. Are you using a pre-release version of Frameworks 5.97 (which hasn't been released yet)? If not, then you'll need to wait for it to be released and then upgrade to it before you can test whether the bug has been fixed or not.

(In reply to Nate Graham from comment #26)
> This bug is listed as fixed in Frameworks 5.97. Are you using a pre-release
> version of Frameworks 5.97 (which hasn't been released yet)? If not, then
> you'll need to wait for it to be released and then upgrade to it before you
> can test whether the bug has been fixed or not.

Ho sorry, no I'm always with 5.96... Thanks

Thank you, I can confirm that the issue is fixed with KDE Frameworks 5.97.0!