Summary: | G'MIC has problems with offset positioned layers | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | amyspark <amy> |
Component: | G'Mic for Krita | Assignee: | amyspark <amy> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | David.Tschumperle, halla, thetwo222 |
Priority: | NOR | ||
Version First Reported In: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/43093d09bb0a9f9d5fcd3ec9f136314cee6a7212 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
Compose channels bug
Extract foreground [interactive] bug gif |
Description
amyspark
2022-05-06 21:32:03 UTC
Created attachment 148615 [details]
Extract foreground [interactive] bug
*** Bug 453483 has been marked as a duplicate of this bug. *** I found some other: “tones to layers” “tiles to layers” “fade layers” “morph layers” “colors to layers” “multiscale operator “align layers” CC'ing David, I've verified we do send the layer position correctly. It seems that gui_autocrop_layers in the G'MIC stdlib (which all filters seem to use) repositions the generated layers from (0, 0) instead of from the provided layer position. *** Bug 453961 has been marked as a duplicate of this bug. *** *** Bug 453507 has been marked as a duplicate of this bug. *** Thanks for your comment! Automatically switching the status of this bug to REPORTED so that the KDE team knows that the bug is ready to get confirmed. In the future you may also do this yourself when providing needed information. krita-nightly-x64-5.1.0-prealpha-0c31a5bcc5 Some tests have been carried out here, and it is found that some cases work normally: “channels to layers”: 1.with selection:normal 2.without selection:The new layers are in the upper left corner “Extract foreground [interactive]”: 1.with selection:normal 2.without selection:The new layers are in the upper left corner “tones to layers”:normal “tiles to layers”:normal “fade layers”:normal “morph layers”:normal “colors to layers”:This filter doesn't seem to work? I don't see any change. If there is no selection, it will change to the upper left corner. “multiscale operator“: 1.with selection:normal 2.without selection:The new layers are in the upper left corner “align layers”: The effect of applying filter is different from that of preview…… If there is no selection, the picture will be generated in the center of the canvas Created attachment 149276 [details]
gif
In addition, are filters such as "stroke" and "drop shadow" better aligned according to the center? (and it may be better not to be restricted by selection...)
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1464 Git commit 43093d09bb0a9f9d5fcd3ec9f136314cee6a7212 by L. E. Segovia. Committed on 02/06/2022 at 16:19. Pushed by lsegovia into branch 'master'. G'MIC: fix relative layer positioning There are some filters that are still broken, these have been reported upstream. Ref https://github.com/dtschump/gmic/issues/385 M +3 -2 plugins/extensions/qmic/kis_qmic_import_tools.h M +5 -2 plugins/extensions/qmic/kis_qmic_simple_convertor.cpp https://invent.kde.org/graphics/krita/commit/43093d09bb0a9f9d5fcd3ec9f136314cee6a7212 |