| Summary: | Simon Stålenhag’s Wallpapers change more than once a day | ||
|---|---|---|---|
| Product: | [Plasma] Plasma Workspace Wallpapers | Reporter: | Nicola Smaniotto <smaniotto.nicola> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate, qydwhotmail, wengxt |
| Priority: | NOR | ||
| Version: | 5.24.4 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/kdeplasma-addons/commit/7d152446ce2c34922593202453726984cd66f797 | Version Fixed In: | 5.24.6 |
|
Description
Nicola Smaniotto
2022-05-04 15:01:26 UTC
Just that provider, or any one? (In reply to Nate Graham from comment #1) > Just that provider, or any one? I checked them all, Flickr has the same issue. I used Wikimedia Commons until the other day, so I never noticed. If I understand the code correctly, the issue comes from [0]. The image is randomly chosen each time, there isn't a daily image provided by upstream. If I may suggest a fix, we could switch to a deterministic function, like going through one image per day in order or using a hash of the date. This would make the code fetch always the same image in any specific day. [0] https://invent.kde.org/plasma/kdeplasma-addons/-/blob/v5.24.4/dataengines/potd/simonstalenhagprovider.cpp#L58 Not fully fixed: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/139 https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/141 (for 5.24.6) and https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/140 Git commit d3bb3dc1d96ef7d734503e6d78dc3ce35106a628 by Fushan Wen. Committed on 05/05/2022 at 02:16. Pushed by fusionfuture into branch 'Plasma/5.24'. wallpapers/potd: Give random chooser a seed in simonstalenhagprovider Make the seed depend on the current date. M +7 -3 dataengines/potd/simonstalenhagprovider.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/d3bb3dc1d96ef7d734503e6d78dc3ce35106a628 Git commit 326ae3a24ccb1f1b526f4742a84e4ce24046effd by Fushan Wen. Committed on 05/05/2022 at 02:19. Pushed by fusionfuture into branch 'Plasma/5.24'. wallpapers/potd: Give random chooser a seed in flickrprovider Make the seed depend on the current date. FIXED-IN: 5.24.6 M +7 -2 dataengines/potd/flickrprovider.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/326ae3a24ccb1f1b526f4742a84e4ce24046effd Git commit 7fd63273f41469219ac756d87ac53bd9b8f1cb8e by Fushan Wen. Committed on 05/05/2022 at 10:22. Pushed by fusionfuture into branch 'master'. wallpapers/potd: Give random chooser a seed in simonstalenhagprovider Make the seed depend on the current date. M +7 -3 wallpapers/potd/plugins/simonstalenhagprovider.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/7fd63273f41469219ac756d87ac53bd9b8f1cb8e Git commit 7d152446ce2c34922593202453726984cd66f797 by Fushan Wen. Committed on 05/05/2022 at 10:22. Pushed by fusionfuture into branch 'master'. wallpapers/potd: Give random chooser a seed in flickrprovider Make the seed depend on the current date. M +7 -3 wallpapers/potd/plugins/flickrprovider.cpp https://invent.kde.org/plasma/kdeplasma-addons/commit/7d152446ce2c34922593202453726984cd66f797 Git commit 52e13a84384723a875ba60220c3201921dce7a0d by Fushan Wen. Committed on 09/05/2022 at 23:25. Pushed by fusionfuture into branch 'master'. wallpapers/potd: Check last update date after resume from sleep It's unnecessary to force update the wallpaper if the day is not changed, instead, we can calculate the time remaining until tomorrow, and update the update timer's interval. M +18 -2 wallpapers/potd/plugins/potdprovidermodel.cpp M +1 -0 wallpapers/potd/plugins/potdprovidermodel.h https://invent.kde.org/plasma/kdeplasma-addons/commit/52e13a84384723a875ba60220c3201921dce7a0d |