Bug 453366

Summary:	HSV slider arrows don't respond to value changes made with the textboxes
Product:	[Applications] krita	Reporter:	tomtomtomreportingin
Component:	Color Selectors	Assignee:	Krita Bugs <krita-bugs-null>
Status:	REPORTED ---
Severity:	minor	CC:	halla
Priority:	NOR	Keywords:	triaged
Version:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description tomtomtomreportingin 2022-05-04 02:39:11 UTC

git ec92085

SUMMARY
The HSV slider arrows of the Specific Color Selector docker don't respond if the user types values into the textboxes or clicks through steps. However, the actual color does change. This issue does not occur with the RGB slider.

STEPS TO REPRODUCE
1. Click the rightside step (arrow) buttons on the sides of the HSV sliders, or enter values.

OBSERVED RESULT
Arrows under the sliders don't respond.

EXPECTED RESULT
The arrows should respond to the new value.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.90.0
Qt Version: 5.12.12 (appimage)

ADDITIONAL INFORMATION
Another inconsistency I noticed is that holding the steps in the RGB slider will stop at 1 step but holding the steps in the HSV slider will keep going through steps. The latter behavior is probably preferable?

Comment 1 Halla Rempt 2022-05-10 12:54:38 UTC

I cannot reproduce this in the master branch.

Comment 2 Bug Janitor Service 2024-09-03 22:44:47 UTC

A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/2231

Comment 3 Freya Lupen 2024-09-10 14:54:45 UTC

Git commit dba6fe1fe23aa7320c7dd15f99c628a5732a6fbb by Freya Lupen.
Committed on 10/09/2024 at 14:53.
Pushed by freyalupen into branch 'master'.

Specific ColSel: Fix holding down spinbox arrows

Updating the min/max spinbox value every update interfered with
holding down the step arrows. So only update it if it's changed.

M  +6    -2    libs/widgets/kis_color_input.cpp

https://invent.kde.org/graphics/krita/-/commit/dba6fe1fe23aa7320c7dd15f99c628a5732a6fbb

Comment 4 Freya Lupen 2024-09-10 14:57:07 UTC

Git commit 48b28f2b3c9b2a4355eb327f8aa96471315c962d by Freya Lupen.
Committed on 10/09/2024 at 14:55.
Pushed by freyalupen into branch 'krita/5.2'.

Specific ColSel: Fix holding down spinbox arrows

Updating the min/max spinbox value every update interfered with
holding down the step arrows. So only update it if it's changed.
(cherry picked from commit dba6fe1fe23aa7320c7dd15f99c628a5732a6fbb)

M  +6    -2    libs/widgets/kis_color_input.cpp

https://invent.kde.org/graphics/krita/-/commit/48b28f2b3c9b2a4355eb327f8aa96471315c962d