Bug 453225

Summary: Crash on launch, SIGSEGV
Product: [Applications] filelight Reporter: Bart Ribbers <bribbers>
Component: generalAssignee: Martin Sandsmark <martin.sandsmark>
Status: RESOLVED FIXED    
Severity: crash CC: nate
Priority: NOR    
Version First Reported In: 22.04.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Bart Ribbers 2022-04-30 11:27:47 UTC
SUMMARY
Filelight for a while has been crashing on launch (definitely already did on 21.12 as well), seemingly with SIGSEGV.

Backtrace:


Thread 1 "filelight" received signal SIGSEGV, Segmentation fault.
0x000055555556bed2 in sincos (angleRadians=1.014472627721704, Sin=0x7fffff7ff038, Cos=0x7fffff7ff030) at /home/buildozer/aports/community/filelight/src/filelight-22.04.0/src/radialMap/sincos.h:23
23      /home/buildozer/aports/community/filelight/src/filelight-22.04.0/src/radialMap/sincos.h: No such file or directory.
(gdb) bt
#0  0x000055555556bed2 in sincos (angleRadians=1.014472627721704, Sin=0x7fffff7ff038, Cos=0x7fffff7ff030)
    at /home/buildozer/aports/community/filelight/src/filelight-22.04.0/src/radialMap/sincos.h:23
#1  0x000055555556bed7 in sincos (angleRadians=<optimized out>, Sin=0x7fffff7ff068, Cos=0x7fffff7ff060)
    at /home/buildozer/aports/community/filelight/src/filelight-22.04.0/src/radialMap/sincos.h:23
#2  0x000055555556bed7 in sincos (angleRadians=<optimized out>, Sin=0x7fffff7ff098, Cos=0x7fffff7ff090)
    at /home/buildozer/aports/community/filelight/src/filelight-22.04.0/src/radialMap/sincos.h:23

(this goes on forever)

STEPS TO REPRODUCE
1. Launch Filelight

OBSERVED RESULT
Filelight crashes just after the window has launched

EXPECTED RESULT
Filelight to not crash, obviously

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Alpine Linux edge
(available in About System)
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3 with KDE patches

ADDITIONAL INFORMATION
This system uses Musl libc which seems to be where it goes wrong. https://invent.kde.org/utilities/filelight/-/blob/master/src/radialMap/sincos.h reveals it checks if it's not running on Glibc which in this case is true. qmath.h is provided by qt5-qtbase, but I'm not sure it's looking at the right location for it.
Comment 1 Nate Graham 2022-05-03 14:52:38 UTC
Can you try git master and see if that's any better? There has been some huge refactoring.
Comment 2 Bart Ribbers 2022-05-08 18:19:03 UTC
I'd try but git master doesn't compile on Musl currently due to using S_BLKSIZE (which seems to be glibc and uclibc only):

/home/bart/Documents/Git/alpine/aports/community/filelight/src/filelight-da8221a96c72f31eac095fa6d8f43b104298bbf8/src/posixWalker.cpp: In member function 'void POSIXWalker::next()':
/home/bart/Documents/Git/alpine/aports/community/filelight/src/filelight-da8221a96c72f31eac095fa6d8f43b104298bbf8/src/posixWalker.cpp:102:44: error: 'S_BLKSIZE' was not declared in this scope
  102 |         m_entry.size = statbuf.st_blocks * S_BLKSIZE;
      |                                            ^~~~~~~~~
Comment 3 Bug Janitor Service 2022-05-23 04:35:39 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Bart Ribbers 2022-05-23 13:04:13 UTC
Well I fixed that crash, https://invent.kde.org/utilities/filelight/-/merge_requests/37/diffs

Master builds for me now and it doesn't SIGSEGV anymore so that's great. Too bad 22.04 has to remain broken but I guess it's not worth the effort to fix it.
Comment 5 Nate Graham 2022-05-23 13:20:15 UTC
Not merged yet, so this ticket needs to stay open until it is. :)
Comment 6 Bart Ribbers 2022-05-23 13:30:12 UTC
Well the MR I linked has nothing to do with this bug, that just fixes the build that prevented me from using Filelight 22.04.1 and git master  ;)

So I'd think this bug can be closed as it's fixed in git master already
Comment 7 Nate Graham 2022-05-23 13:31:33 UTC
Aha!