Bug 453172

Summary: Revise wording for "Leading Column Padding"
Product: [Applications] dolphin Reporter: Jin Liu <ad.liu.jin>
Component: view-engine: details modeAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: kfm-devel, nate
Priority: NOR    
Version: 22.04.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://invent.kde.org/system/dolphin/commit/ca0d0bb322925e2119f13f76d8e9643d24cbf3e0 Version Fixed In:
Sentry Crash Report:

Description Jin Liu 2022-04-29 05:35:10 UTC 
SUMMARY
The right-click menu in the header of details view has an item "Leading Column Padding", which actually adds padding on BOTH sides, not only the left. So perhaps this could have a more accruate wording, e.g. "Extra Padding On Both Sides"?

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version:
Comment 1 Nate Graham 2022-05-03 17:43:57 UTC 
Yeah, it should. Changing strings is really easy; would you like to submit a merge request to make that change? The file you'd need to change is src/views/dolphinview.cpp. Just search for the text in that file.
Comment 2 Jin Liu 2022-05-04 10:06:23 UTC 
OK. Merge request created:
https://invent.kde.org/system/dolphin/-/merge_requests/386?commit_id=058c0ed6219aa53208e6479a82567b3a4adbeca6

However, that source file has "leadingPadding" in function names everywhere. I suppose those need not change since, er, it ain't broken?
Comment 3 Felix Ernst 2022-05-26 08:31:17 UTC 
Git commit ca0d0bb322925e2119f13f76d8e9643d24cbf3e0 by Felix Ernst, on behalf of Jin Liu.
Committed on 26/05/2022 at 08:31.
Pushed by felixernst into branch 'master'.

Change wording "Leading Column Padding" to "Side Padding"

Since it actually adds padding on both left and right sides,
"Side Padding" might be more accurate.

This change is also propagated to variable and method names.

M  +2    -2    doc/index.docbook
M  +3    -0    src/CMakeLists.txt
M  +7    -7    src/kitemviews/kitemlistheader.cpp
M  +3    -3    src/kitemviews/kitemlistheader.h
M  +9    -9    src/kitemviews/kitemlistview.cpp
M  +1    -1    src/kitemviews/kitemlistview.h
M  +7    -7    src/kitemviews/kitemlistwidget.cpp
M  +4    -4    src/kitemviews/kitemlistwidget.h
M  +6    -6    src/kitemviews/kstandarditemlistwidget.cpp
M  +1    -1    src/kitemviews/kstandarditemlistwidget.h
M  +19   -19   src/kitemviews/private/kitemlistheaderwidget.cpp
M  +5    -5    src/kitemviews/private/kitemlistheaderwidget.h
M  +2    -2    src/settings/dolphin_detailsmodesettings.kcfg
A  +8    -0    src/settings/dolphin_detailsmodesettings.upd
M  +1    -1    src/views/dolphinitemlistview.cpp
M  +10   -10   src/views/dolphinview.cpp
M  +1    -1    src/views/dolphinview.h

https://invent.kde.org/system/dolphin/commit/ca0d0bb322925e2119f13f76d8e9643d24cbf3e0