| Summary: | folderview to linked activity files does not work | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio-extras | Reporter: | Alexandre Pereira <pereira.alex> |
| Component: | default | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alx.kuzza, hein, mvourlakos, nate, qydwhotmail, robby.engelmann |
| Priority: | NOR | Keywords: | regression |
| Version: | 22.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=447558 | ||
| Latest Commit: | https://invent.kde.org/network/kio-extras/commit/270f2487c824713304f8b227fb14fa7e0c5c369c | Version Fixed In: | 22.12 |
| Sentry Crash Report: | |||
|
Description
Alexandre Pereira
2022-04-28 02:58:33 UTC
same here since perhaps 2-3 weeks... Operating System: openSUSE Tumbleweed 20220502 KDE Plasma Version: 5.24.80 KDE Frameworks Version: 5.94.0 Qt Version: 5.15.2 Kernel Version: 5.17.4-1-default (64-bit) Graphics Platform: Wayland Processors: 8 × Intel® Core™ i7-10510U CPU @ 1.80GHz Memory: 31.0 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics Manufacturer: TUXEDO Product Name: TUXEDO System Version: Not Applicable btw I noticed that if I use kf5 git and plasma git, but kde-gear stable version ( especially dolphin and kio/kio-extras ), the bug doesn't happen. *** Bug 397004 has been marked as a duplicate of this bug. *** Unfortunately nowadays almost no code contributors use activities anymore. So if someone has interest in fixing the bug, please submit a merge request. Confirmed, still an issue for Plasma 5.26.2-1.1 Sill a regression from previous version of Plasma. Commit 0e8f100d64bb3799f167a9b47c8c3aaaebf7775a introduced this problem. In what git repo? Project: kio-extras ..
This is a proposed change:
diff --git a/activities/KioActivities.cpp b/activities/KioActivities.cpp
index 96a139e68..23691943f 100644
--- a/activities/KioActivities.cpp
+++ b/activities/KioActivities.cpp
@@ -57,8 +57,11 @@ public:
const auto fullPath = url.adjusted(QUrl::StripTrailingSlash).path();
const auto path = QStringView(fullPath).mid(fullPath.startsWith(QLatin1Char('/')) ? 1 : 0);
- if (activity) {
- *activity = path.mid(0, path.indexOf(QStringLiteral("/")) - 1).toString();
+ if (activity && path.length() != 0) {
+ if (path.indexOf(QStringLiteral("/"))!=-1)
+ *activity = path.mid(0, path.indexOf(QStringLiteral("/"))).toString();
+ else
+ *activity = path.toString();
}
if (filePath) {
Tested locally. Working as expected in dolphin and folder view.
Awesome, please do feel free to submit a patch! I can help with anything. (In reply to Nate Graham from comment #9) > Awesome, please do feel free to submit a patch! I can help with anything. Well, cannot create a branch in that project to submit a MR :( (In reply to Nate Graham from comment #9) > Awesome, please do feel free to submit a patch! I can help with anything. My username in invent.kde.org is @smithey. You fork the repo; it's the same as the GitHub workflow, if you're familiar with that. See https://community.kde.org/Infrastructure/GitLab#Submitting_a_Merge_Request. A possibly relevant merge request was started @ https://invent.kde.org/network/kio-extras/-/merge_requests/197 Git commit a1f961060a43dae6ddaea969efe2620fbb5fa06b by Nicolas Fella, on behalf of Alexander Kuznetsov. Committed on 18/11/2022 at 10:43. Pushed by nicolasfella into branch 'master'. [activities] Fix showing associated files M +2 -2 activities/KioActivities.cpp https://invent.kde.org/network/kio-extras/commit/a1f961060a43dae6ddaea969efe2620fbb5fa06b Git commit 270f2487c824713304f8b227fb14fa7e0c5c369c by Nicolas Fella, on behalf of Alexander Kuznetsov. Committed on 18/11/2022 at 10:44. Pushed by nicolasfella into branch 'release/22.12'. [activities] Fix showing associated files (cherry picked from commit a1f961060a43dae6ddaea969efe2620fbb5fa06b) M +2 -2 activities/KioActivities.cpp https://invent.kde.org/network/kio-extras/commit/270f2487c824713304f8b227fb14fa7e0c5c369c |