| Summary: | Can't connect to a Windows samba share with samba-libs 4.16 | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio-extras | Reporter: | Jiri Palecek <jpalecek> |
| Component: | Samba | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, bertronika, derek.d.smiley, j.straight-kde, mihai.dontu, nate, nvaert1986, qydwhotmail, schmidicom, sitter |
| Priority: | NOR | ||
| Version: | 21.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/kio-extras/commit/eea1ecae3624c90b63a0c1378313fe8d26b00db1 | Version Fixed In: | 22.08.2 |
| Sentry Crash Report: | |||
|
Description
Jiri Palecek
2022-04-27 16:22:53 UTC
I take it your credentials are correct? If so please file this upstream at bugzilla.samba.org you are getting EINVAL which seems an entirely unreasonable return value there. (In reply to Harald Sitter from comment #1) > I take it your credentials are correct? If so please file this upstream at > bugzilla.samba.org you are getting EINVAL which seems an entirely > unreasonable return value there. No, these credentials are, in fact, wrong. I need to connect to the system as a different user, but that should be no problem, shouldn't it? It used to pop up a box where I entered a username/password, and often it just connects right away. Another problem is that I don't have a Samba bugzilla account. Well, upstream shouldn't break compatibility there. We handle both EPERM and EACCESS so even the commit message says things should remain working, but they do not so that's an upstream regression from where I'm standing. A similar problem with nautilus was already discussed here: https://bugzilla.samba.org/show_bug.cgi?id=14983 They resolved it by handling/ignoring EINVAL returns: https://gitlab.gnome.org/GNOME/gvfs/-/issues/611 The Samba team has backported the change, and that this change will be reverted is very unlikely. https://github.com/samba-team/samba/commits/samba-4.15.7/source3/libsmb/libsmb_server.c Please adjust your code in KIO/Dolphin. I'm sure I'm not the only user who depends on a working implementation of smb in Dolphin. I guess this is one of those unpleasant situations where upstream did something naughty and broke client software, so client software needs to deal with it. Shouldn't happen... but does happen. :( I can confirm the issue exists in Fedora 36 (plasma 5.24.5, frameworks 5.93.0, samba 4.16.1-4). A possibly relevant merge request was started @ https://invent.kde.org/network/kio-extras/-/merge_requests/165 (In reply to Bug Janitor Service from comment #8) > A possibly relevant merge request was started @ > https://invent.kde.org/network/kio-extras/-/merge_requests/165 On my installation this patch works. Thank you. :) Commenting to advise this bit me with samba-libs 4.15.9. ``` Operating System: Kubuntu 22.04 KDE Plasma Version: 5.24.6 KDE Frameworks Version: 5.95.0 Qt Version: 5.15.3 Kernel Version: 5.15.0-43-generic (64-bit) Samba version: 4.15.9 ``` *** Bug 457661 has been marked as a duplicate of this bug. *** I'm experiencing the bug with 4.16.x too, but I also had the exact same issue with 4.15.x. I actually upgraded from 4.15.x to 4.16.x in Gentoo in the hope this would resolve the issue, but it did not. How long are you going to fight your little ideology war on the backs of your users? The Samba developers are not going to reverse this change and they are not going to change their ways just because you leave your users alone with this bug. There is a "merge request" that solves the current problem and still nothing happens here... If you have a problem with the Samba developers then please discuss it with them and don't take your users hostage. Translated with www.DeepL.com/Translator (free version) Git commit 95ebf9a66c4f503dd41205abadd7a522e758d974 by Harald Sitter, on behalf of Anthony Hung. Committed on 06/09/2022 at 12:54. Pushed by sitter into branch 'release/22.08'. smb/kio_smb_browse: Check error code `EINVAL` to prompt the password dialog With `samba-libs` >= 4.16, when user connect to the windows file sharing with incorrect user credential, the error code is `EINVAL`. The user should get the password dialog to enter username and password if the error code is `EINVAL`. Reference URL: https://bugzilla.samba.org/show_bug.cgi?id=14983 https://gitlab.gnome.org/GNOME/gvfs/-/issues/611 M +1 -1 smb/kio_smb_browse.cpp https://invent.kde.org/network/kio-extras/commit/95ebf9a66c4f503dd41205abadd7a522e758d974 Git commit eea1ecae3624c90b63a0c1378313fe8d26b00db1 by Harald Sitter, on behalf of Anthony Hung. Committed on 06/09/2022 at 12:59. Pushed by sitter into branch 'master'. smb/kio_smb_browse: Check error code `EINVAL` to prompt the password dialog With `samba-libs` >= 4.16, when user connect to the windows file sharing with incorrect user credential, the error code is `EINVAL`. The user should get the password dialog to enter username and password if the error code is `EINVAL`. Reference URL: https://bugzilla.samba.org/show_bug.cgi?id=14983 https://gitlab.gnome.org/GNOME/gvfs/-/issues/611 M +1 -1 smb/kio_smb_browse.cpp https://invent.kde.org/network/kio-extras/commit/eea1ecae3624c90b63a0c1378313fe8d26b00db1 |