Summary: | Name field doesn't seem to have any history; cannot undo or redo any text changes with Ctrl+Z or Shift+Ctrl+Z | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | redashesyellowflowers |
Component: | Open/save dialogs | Assignee: | KIO Bugs <kio-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.samirh78, kdelibs-bugs, nate |
Priority: | NOR | Keywords: | usability |
Version: | 5.93.0 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kio/commit/42395623a8fb577a70188b7db6d2b5c42386867c | Version Fixed In: | 5.97 |
Description
redashesyellowflowers
2022-04-25 15:52:00 UTC
Git commit 331aad501acea58013a7cf89e18919f945394396 by Ahmad Samir. Committed on 03/07/2022 at 19:26. Pushed by ahmadsamir into branch 'master'. KFileWidget: remove location history dummy-entry related code This code was used in m_locationEdit ("Name" combobox). The issue with this code is that it ultimately invokes QLineEdit::setText(), which resets the undo/redo steps for the text in the lineedit at index -1, with every key press event. So we lose one functionality, showing the corresponding icon for the url in the lineedit, but gain the undo/redo functionality, the latter being a functionality that is available/expectted in all Qt/KDE lineedits. 0x00007ffff6b9aa40 in QLineEdit::setText(QString const&)@plt () from /lib64/libQt5Widgets.so.5 0x00007ffff6cb8a83 in QComboBoxPrivate::_q_dataChanged (this=0x5555558f9560, topLeft=..., bottomRight=...) 0x00007ffff5e23235 in QAbstractItemModel::dataChanged (this=this@entry=0x5555558f9800, _t1=..., _t2=..., _t3=...) 0x00007ffff66d7780 in QStandardItemModelPrivate::itemChanged (this=<optimized out>, item=item@entry=0x555555d8cfe0, roles=...) 0x00007ffff66d7ff8 in QStandardItem::setData (this=0x555555d8cfe0, value=..., role=<optimized out>) 0x00007ffff66db16c in QStandardItemModel::setData (role=1, value=..., index=..., this=0x5555558f9800) QStandardItemModel::setData (this=this@entry=0x5555558f9800, index=..., value=..., role=role@entry=1) 0x00007ffff6cb369f in QComboBox::setItemIcon (this=<optimized out>, index=index@entry=0, icon=...) 0x00007ffff7f30501 in KFileWidgetPrivate::setDummyHistoryEntry (this=this@entry=0x5555556ddbb0, text=..., icon=..., usePreviousPixmapIfNull=usePreviousPixmapIfNull@entry=true) M +11 -107 src/filewidgets/kfilewidget.cpp https://invent.kde.org/frameworks/kio/commit/331aad501acea58013a7cf89e18919f945394396 Git commit 42395623a8fb577a70188b7db6d2b5c42386867c by Christoph Cullmann, on behalf of Ahmad Samir. Committed on 15/05/2023 at 19:48. Pushed by cullmann into branch 'master'. KFileWidget: remove location history dummy-entry related code This code was used in m_locationEdit ("Name" combobox). The issue with this code is that it ultimately invokes QLineEdit::setText(), which resets the undo/redo steps for the text in the lineedit at index -1, with every key press event. So we lose one functionality, showing the corresponding icon for the url in the lineedit, but gain the undo/redo functionality, the latter being a functionality that is available/expectted in all Qt/KDE lineedits. 0x00007ffff6b9aa40 in QLineEdit::setText(QString const&)@plt () from /lib64/libQt5Widgets.so.5 0x00007ffff6cb8a83 in QComboBoxPrivate::_q_dataChanged (this=0x5555558f9560, topLeft=..., bottomRight=...) 0x00007ffff5e23235 in QAbstractItemModel::dataChanged (this=this@entry=0x5555558f9800, _t1=..., _t2=..., _t3=...) 0x00007ffff66d7780 in QStandardItemModelPrivate::itemChanged (this=<optimized out>, item=item@entry=0x555555d8cfe0, roles=...) 0x00007ffff66d7ff8 in QStandardItem::setData (this=0x555555d8cfe0, value=..., role=<optimized out>) 0x00007ffff66db16c in QStandardItemModel::setData (role=1, value=..., index=..., this=0x5555558f9800) QStandardItemModel::setData (this=this@entry=0x5555558f9800, index=..., value=..., role=role@entry=1) 0x00007ffff6cb369f in QComboBox::setItemIcon (this=<optimized out>, index=index@entry=0, icon=...) 0x00007ffff7f30501 in KFileWidgetPrivate::setDummyHistoryEntry (this=this@entry=0x5555556ddbb0, text=..., icon=..., usePreviousPixmapIfNull=usePreviousPixmapIfNull@entry=true) M +11 -107 src/filewidgets/kfilewidget.cpp https://invent.kde.org/frameworks/kio/commit/42395623a8fb577a70188b7db6d2b5c42386867c |