Bug 452955

Summary: konsole doesn't to stop scrolling on output
Product: [Applications] konsole Reporter: Michael <voron1>
Component: historyAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal CC: a.samirh78, jjm, nate
Priority: NOR    
Version: 22.04.0   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Michael 2022-04-24 19:31:25 UTC
SUMMARY
***
konsole used to stop scrolling on output if you scroll up, which allows you to read or copy what's already been outputted. But since 22.04 it doesn't stop and keeps scrolling if the program running keeps outputting. 
***
KDE Plasma: 5.24.4
KDE Gear: 22.04
Comment 1 Ahmad Samir 2022-05-03 09:43:50 UTC
I guess you're have the scrolling set to "Fixed size", which means this a duplicate of bug 453112.

*** This bug has been marked as a duplicate of bug 453112 ***
Comment 2 Michael 2022-05-03 10:12:38 UTC
(In reply to Ahmad Samir from comment #1)
> I guess you're have the scrolling set to "Fixed size", which means this a
> duplicate of bug 453112.
> 
> *** This bug has been marked as a duplicate of bug 453112 ***

I tested !645 and it didn't help. It might be a duplicate, from just looking at it, but something else is going on.
Comment 3 Michael 2022-05-03 10:15:11 UTC
or do I need to apply !568 too?
Comment 4 Ahmad Samir 2022-05-03 10:25:41 UTC
No, !568 is already included in 22.04 AFIACS.
Comment 5 Michael 2022-05-03 10:30:54 UTC
Okay. Upon more careful examination, it turns out the fix works if the output is spit out in separate lines, like `while sleep 1; do date; done`
However, the reason I thought it didn't work, is because I was testing it with `cat /dev/urandom | base64`, which spits out one long noodle, and konsole I guess is linewrapping (?), and in that case the fix doesn't work.
Comment 6 Ahmad Samir 2022-05-03 10:42:36 UTC
OK, so it's the same bug, right? could you post your comments in the other report? (so that all info is in one place).
Comment 7 ninjalj 2022-05-24 11:11:03 UTC
Git commit d2ca202abd4e6b415a7647927db493337092d5f3 by Luis Javier Merino Morán.
Committed on 24/05/2022 at 10:51.
Pushed by tcanabrava into branch 'master'.

Fix scroll position jumps regression

Commit d37d3ac1 "CompactHistoryScroll: Remove _maxLineCount + 5 lines at
a time" caused a regression: addHistLine queried the number of lines in
history before and after adding a line, and if it had not incremented it
assumed one line entered history and another was dropped at the other
end.  Now, lines are dropped from history in batches, so take care of
that.

Very similar to the regression fixed at 7a1e4768, only this one is about
keeping the scroll position on the presence of scroll, and that other
one is about keeping the selection.

Thanks to the bug reporters Michael and Luke-Jr for the heads-up.
Related: bug 453112

M  +6    -4    src/Screen.cpp

https://invent.kde.org/utilities/konsole/commit/d2ca202abd4e6b415a7647927db493337092d5f3
Comment 8 ninjalj 2022-06-01 22:26:50 UTC
Git commit a6fce70f6c4e4d355c14475be8f5669a83c7023f by Luis Javier Merino Morán.
Committed on 01/06/2022 at 22:16.
Pushed by ahmadsamir into branch 'release/22.04'.

Fix scroll position jumps regression

Commit d37d3ac1 "CompactHistoryScroll: Remove _maxLineCount + 5 lines at
a time" caused a regression: addHistLine queried the number of lines in
history before and after adding a line, and if it had not incremented it
assumed one line entered history and another was dropped at the other
end.  Now, lines are dropped from history in batches, so take care of
that.

Very similar to the regression fixed at 7a1e4768, only this one is about
keeping the scroll position on the presence of scroll, and that other
one is about keeping the selection.

Thanks to the bug reporters Michael and Luke-Jr for the heads-up.
Related: bug 453112
(cherry picked from commit d2ca202abd4e6b415a7647927db493337092d5f3)

M  +4    -4    src/Screen.cpp

https://invent.kde.org/utilities/konsole/commit/a6fce70f6c4e4d355c14475be8f5669a83c7023f
Comment 9 Jonathan Marten 2022-06-09 13:30:12 UTC
*** Bug 451429 has been marked as a duplicate of this bug. ***