Bug 452792

Summary: Environment Canada’s 7 Day Forecast is Incorrectly Displayed as 12 or 13 Day Forecast
Product: [Unmaintained] kdeplasma-addons Reporter: Wing Hong Chan <winghongchan>
Component: WeatherAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kdeplasma-addons/commit/1516dc73a16b9f72fec1315ac3d63f27147dd696 Version Fixed/Implemented In: 5.27
Sentry Crash Report:
Attachments: Weather Widget showing a 7-day forecast as a 13-day forecast.

Description Wing Hong Chan 2022-04-20 12:09:22 UTC 
Created attachment 148266 [details]
Weather Widget showing a 7-day forecast as a 13-day forecast.

SUMMARY
In the weather applet, the Environment Canada (ECCC or ENVCAN) 7-day weather forecast is shown as a thirteen-day forecast. 

Environment Canada weather forecasts give daytime and nighttime conditions and temperatures, instead of one condition and highs and lows for the day. 
In the Plasma weather report widget, however, the daytime and nighttime conditions are shown as two separate days, leading the 7-day day and night forecast being blown up to 13 days. 

This is one cause of the bug where the widget is squished in the system tray https://bugs.kde.org/show_bug.cgi?id=394809 but that one aims to better fit a 13-day forecast in the square system tray popup, which is not this bug. 

STEPS TO REPRODUCE
1. Open the Weather Report (widget) Settings
2. Choose a Canadian city for the Location, using Environment Canada as the source. 
3. View the forecast in the widget. 

OBSERVED RESULT
The 7-day forecast incorrectly appears as a 12 or 13-day forecast. It separates daytime and nighttime conditions for each day into two columns. 

EXPECTED RESULT
The 7-day forecast tab should be called “7 Days” and the day/night forecast for each day should not be shown as two separate days. Ideally it would show the forecasts in 2 rows (day and night) and 7 columns (days of the week), just like the Environment Canada website, which would also fit nicely into the systray popup. You may check how Environment Canada weather website displays the forecasts here: https://weather.gc.ca/canada_e.html

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon 5.24
KDE Plasma Version: 5.24
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
Comment 1 Bug Janitor Service 2022-11-20 15:02:28 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/278
Comment 2 Ismael Asensio 2022-11-21 22:35:37 UTC 
Git commit 1516dc73a16b9f72fec1315ac3d63f27147dd696 by Ismael Asensio.
Committed on 21/11/2022 at 21:55.
Pushed by iasensio into branch 'master'.

applets/weather: Show forecast in two rows for envcan provider

The envcan provider (Environment Canada Service) produces a
forecast model with 13 items (7-day forecast and 6 nights).

Show them on a two row layout, so its easier to visually parse
and helps avoiding visual bugs on constrained spaces (system
tray popup) due to a really long width.

Ideally, this would be better set-up by the dataengine but,
since they will be deprecated soon and there are alreay too many
indirection layers we can do an educated guess here.
Related: bug 394809
FIXED-IN: 5.27

M  +24   -8    applets/weather/package/contents/ui/ForecastView.qml
M  +1    -0    applets/weather/package/contents/ui/FullRepresentation.qml
M  +1    -0    applets/weather/package/contents/ui/SwitchPanel.qml
M  +22   -2    applets/weather/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/1516dc73a16b9f72fec1315ac3d63f27147dd696