Bug 452756

Summary: Color sampler does not work correctly in Wrap Around mode
Product: [Applications] krita Reporter: fuhrmann
Component: ToolsAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: alvin, penguinflyer2222
Priority: NOR    
Version First Reported In: 5.0.5   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description fuhrmann 2022-04-19 08:46:08 UTC
SUMMARY
***
When in "Wrap Around" mode, the color sampler only works only in the area of the original image, not in the mirrored tiles.
Since the original image tile is not distinguishable from the other tiles in this mode, one would expect to sample the color under the cursor, instead of white.
***


STEPS TO REPRODUCE
1. open a new image
2. fill it with red
3. center the image and zoom out, so that it occupies only part of the screen
4. switch on "Wrap Around" mode (whole drawing area turns red
5. change foreground color to black
6. use color sampler on red area OUTSIDE the original image in the center
6. sampled foreground color should be red, but is white!

OBSERVED RESULT
sampled foreground color is white


EXPECTED RESULT
sampled color should be the color of the drawing area under the cursor (red)

SOFTWARE/OS VERSIONS
Windows: 10, 21H2, build 19044.1415


ADDITIONAL INFORMATION
similar to bug# 383894

Hardware:
Processor: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
Processor Speed: 2304 MHz
GFX Driver Name: IntelĀ® UHD Graphics
Shader Version: 5.1
OpenCL* Version: 3.0
* Microsoft DirectX* *
Runtime Version: 12
Hardware-Supported Version: 12
Vendor ID: 8086
Device ID: 9B41
Device Revision: 02
GFX Driver Version: 30.0.101.1660
Dedicated RAM: 0 GB
Shared RAM: 8 GB
Max Supported Displays: 3
GFX Vulcan: 1.3.205
GFX Video BIOS: 1026
Comment 1 Alvin Wong 2022-04-19 14:55:16 UTC
Can reproduce on nightly 59f3789, but this only happens with the Color Sampler tool (P), while using the Ctrl key in freehand brush tool does work in the wrap around clones.
Comment 2 Freya Lupen 2022-09-26 16:31:24 UTC
This works correctly in 5.1.0. I believe it was fixed in this MR, "Merge color picker tool and ctrl+gesture picking": https://invent.kde.org/graphics/krita/-/merge_requests/1519