Bug 452701

Summary:	Timer height cannot be made small enough
Product:	[Plasma] kdeplasma-addons	Reporter:	tusooa <tusooa>
Component:	timer	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	minor	CC:	nate
Priority:	NOR
Version:	5.24.4
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/kdeplasma-addons/commit/ba011368af76abc1abbacab1ccce8075e45a6ae1	Version Fixed In:	5.26
Sentry Crash Report:
Attachments:	Timer height is too large on the vertical panel

Description tusooa 2022-04-17 14:25:22 UTC

Created attachment 148205 [details]
Timer height is too large on the vertical panel

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
On a vertical panel, the widget height of a timer is too large.

STEPS TO REPRODUCE
1. Create a vertical panel on the left edge.
2. Add a timer widget to it.

OBSERVED RESULT
There is too much space below the digits. This wastes a lot of space on the panel.

EXPECTED RESULT
There should be no/little space below the digits.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 5.16.12-gentoo-x86_64 / 5.24.4
(available in About System)
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.2-r14

ADDITIONAL INFORMATION

Comment 1 Fushan Wen 2022-08-05 15:53:14 UTC

Git commit ba011368af76abc1abbacab1ccce8075e45a6ae1 by Fushan Wen.
Committed on 05/08/2022 at 15:19.
Pushed by ngraham into branch 'master'.

applets/timer: add compact representation

The compact representation has 5 layout forms:

1. inPanel, Horizontal: [Icon][Column to show the title and the
   remaining time]
2. inPanel, Vertical: [Column to show the title and the remaining time
   in seconds]
3. Desktop, width is enough to contain the icon and the remaining time
   in a row: [Icon][Column]
4. Desktop, width is not enough: [Icon]
                                 [Column]
5. Desktop, both width and height are not enough: [Icon]

The added compact representation also enables tab focus in the applet.
Related: bug 301861, bug 304923, bug 347492, bug 360996, bug 395182, bug 399930, bug 430289
FIXED-IN: 5.26

A  +200  -0    applets/timer/package/contents/ui/CompactRepresentation.qml     [License: GPL(v3.0+)]
M  +9    -2    applets/timer/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/ba011368af76abc1abbacab1ccce8075e45a6ae1