Summary: | Action "Open Terminal" ignores path context of interacted folder | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Brennan Kinney <polarathene-signup> |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kfm-devel, nate, oioi555x |
Priority: | NOR | Keywords: | regression |
Version: | 21.12.3 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/system/dolphin/commit/9b5f56980bc4d2f399a6b828c94b23f3626c9d21 | Version Fixed In: | 22.08 |
Sentry Crash Report: |
Description
Brennan Kinney
2022-04-15 04:23:56 UTC
I have submitted a patch that allows you to achieve equivalent functionality without resorting to `konsolehere.desktop`. https://invent.kde.org/system/dolphin/-/merge_requests/378 Thank you for your detailed investigation. :) (In reply to oioi555x from comment #1) > I have submitted a patch that allows you to achieve equivalent functionality without resorting to `konsolehere.desktop`. That's great, thank you! Regarding the discussion on Gitlab, my input would be: - Don't show the option "Open Terminal Here" for multiple selection, or disable it. A separate feature request could be made should users want that functionality. It'd be unclear if it should be separate terminal instances, or single window with tabs (but that'd likely depend upon the terminal being opened). Opening as new tabs to an existing window would be undesirable though. - If you do opt to open multiple windows, I agree with the confirmation prompt to avoid mistakes, it's a very annoying UX otherwise (Get New Things has been throwing an API error dialog at times when it fetches content to load, and can spam the error excessively at times). Git commit 9b5f56980bc4d2f399a6b828c94b23f3626c9d21 by Nate Graham, on behalf of oioi 555. Committed on 02/05/2022 at 20:25. Pushed by ngraham into branch 'master'. Re-add "Open Terminal Here" feature This is equivalent to the "Open Terminal Here" feature that existed until Version 20.12. If the user has selected folders, replace "Open Terminal" in the context menu with "Open Terminal Here". When more than 5 folders are selected, a modal window will ask the user if they are sure they want to open all 6 or more terminal windows. In Detail View, users can also select a file, which will open a terminal at the location of that file. FIXED-IN: 22.08 M +2 -2 src/dolphincontextmenu.cpp M +48 -1 src/dolphinmainwindow.cpp M +6 -0 src/dolphinmainwindow.h M +2 -1 src/dolphinpart.rc M +2 -1 src/dolphinui.rc M +2 -2 src/settings/contextmenu/contextmenusettingspage.cpp M +1 -1 src/settings/dolphinsettingsdialog.cpp https://invent.kde.org/system/dolphin/commit/9b5f56980bc4d2f399a6b828c94b23f3626c9d21 |