Summary: | Dolphin crashes after closing it by clicking the Close Tab option in KCommandBar | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kconfigwidgets | Reporter: | Anael <anael> |
Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | a.samirh78, felixernst, kfm-devel, nate |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.91.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kconfigwidgets/commit/556f3b719ddecbf01eacaa286ce609e8322ed870 | Version Fixed In: | 5.94 |
Sentry Crash Report: |
Description
Anael
2022-04-11 23:04:12 UTC
It also happens when closing Dolphin clicking on the 'Dolphin: Quit' option. Can confirm not only for Dolphin but also for Gwenview. A Dolphin-specific merge request was started by the bug reporter themself: https://invent.kde.org/system/dolphin/-/merge_requests/377 Moving this report from Dolphin to KConfigWidgets. Git commit 556f3b719ddecbf01eacaa286ce609e8322ed870 by Ahmad Samir. Committed on 05/05/2022 at 09:41. Pushed by ahmadsamir into branch 'master'. KCommandBar: remove installed event filter in destructor - Start Dolphin, Ctrl+Alt+I to invoked the KCommandBar - Click "Close tab" (crash doesn't happen when you press Enter) - Dolphin is being closed, KCommandBar is being torn down - The eventFilter() tries to access d, which already have been destroyed down, which causes Dolphin to segfault and crash This similar to the issue described here: https://blogs.kde.org/2021/02/20/uniqueptr-difference-between-libstdc-and-libc-crashes-your-application The gist of it is, always remove all installed event filters on child widgets of the private class in the public class's desructor. FIXED-IN: 5.94 M +7 -0 src/kcommandbar.cpp https://invent.kde.org/frameworks/kconfigwidgets/commit/556f3b719ddecbf01eacaa286ce609e8322ed870 |