Bug 452107

Summary:	Final letter in levels not pronounced
Product:	[Applications] gcompris	Reporter:	Øystein Steffensen-Alværvik <epost.kde>
Component:	general	Assignee:	Jazeix Johnny <jazeix>
Status:	RESOLVED FIXED
Severity:	normal	CC:	animtim
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Flatpak
OS:	Linux
Latest Commit:	https://invent.kde.org/education/gcompris/commit/6efe248dc7bbd5500d33c85d5b041cbc833b556e	Version Fixed In:
Sentry Crash Report:

Description Øystein Steffensen-Alværvik 2022-03-31 10:59:34 UTC

SUMMARY
***
In the games "Simple letters" and "Falling words", the final letter the player types before proceeding to the next level does not get pronounced.
Tested with American English and Norwegian Nynorsk voices.
***


STEPS TO REPRODUCE
1. Launch GCompris and launch either of the games "Simple letters" or "Falling words".
2. Play and complete any level

OBSERVED RESULT
All letters the player types on the keyboard are pronounced, except for the final letter typed right before the game starts the next level. So for instance, if the final word to type before the next level is "arm", typing the M will not play its corresponding voice file.

SOFTWARE/OS VERSIONS
Fedora 35
GCompris 2.3 flatpak version from Flathub

Comment 1 animtim 2022-03-31 12:55:50 UTC

Yes, this is not the best but it's expected for now, due to a workaround that was done to avoid conflict between the last letter audio and the bonus audio played when completing a level.

Ideally we would need to add code to detect if the letter voice is playing, then wait for it to be finished before launching the bonus.

@Johnny: if you want to take a look, I tried that but didn't manage to connect to the activity audioVoices.done signal in order to do that. Maybe you can find how to do it.

Comment 2 Jazeix Johnny 2022-03-31 18:32:18 UTC

Hi,

thank you for the report, I can reproduce. I'll take a look as soon as I can

Comment 3 Jazeix Johnny 2022-04-01 15:08:28 UTC

Git commit d3b7787c82d697afb201be48f7e5b5b89ce0dca6 by Johnny Jazeix.
Committed on 01/04/2022 at 15:08.
Pushed by jjazeix into branch 'master'.

gletters, play bonus after the last letter has been spoken.

M  +9    -0    src/activities/gletters/Gletters.qml
M  +2    -2    src/activities/gletters/gletters.js

https://invent.kde.org/education/gcompris/commit/d3b7787c82d697afb201be48f7e5b5b89ce0dca6

Comment 4 Jazeix Johnny 2022-04-01 15:09:17 UTC

Git commit 27d403adf3054ea0d35d1da910fbb5b9077478b0 by Johnny Jazeix.
Committed on 01/04/2022 at 15:09.
Pushed by jjazeix into branch 'KDE/2.0'.

gletters, play bonus after the last letter has been spoken.

M  +9    -0    src/activities/gletters/Gletters.qml
M  +2    -2    src/activities/gletters/gletters.js

https://invent.kde.org/education/gcompris/commit/27d403adf3054ea0d35d1da910fbb5b9077478b0

Comment 5 Jazeix Johnny 2022-12-27 10:31:48 UTC

Git commit 84b1483da891d471ea18e4082765930919fb44d8 by Johnny Jazeix.
Committed on 27/12/2022 at 10:30.
Pushed by jjazeix into branch 'KDE/3.0'.

gletters, play bonus after the last letter has been spoken only if there are voices.
For locales without voices, we play the bonus after inputting the last letter else it is stuck and it never goes to the next level.

M  +4    -0    src/activities/gletters/gletters.js

https://invent.kde.org/education/gcompris/commit/84b1483da891d471ea18e4082765930919fb44d8

Comment 6 Jazeix Johnny 2022-12-27 10:34:54 UTC

Git commit 6efe248dc7bbd5500d33c85d5b041cbc833b556e by Johnny Jazeix.
Committed on 27/12/2022 at 10:33.
Pushed by jjazeix into branch 'master'.

gletters, play bonus after the last letter has been spoken only if there are voices.
For locales without voices, we play the bonus after inputting the last letter else it is stuck and it never goes to the next level.

M  +4    -0    src/activities/gletters/gletters.js

https://invent.kde.org/education/gcompris/commit/6efe248dc7bbd5500d33c85d5b041cbc833b556e