| Summary: | Crashed while doing nothing | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | General | Assignee: | amyspark <amy> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alvin, amy, dimula73, halla, lynx.mw+kde, zackalltrades |
| Priority: | NOR | ||
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/bcff23b8f01e483fdde3807cb19eef6ad7ea4eca | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Crash after closing another document and switching tools | ||
|
Description
acc4commissions
2022-03-30 04:18:27 UTC
I apparently had this (or a related) crash too with a linux build based on 57e7799c6c2f7635cf343a0b43b6347ffd994370 It happened after I closed one of multiple open documents, and switched back to the brush tool, because for some reason, switching documents often activates the wrong tool (one you had used before but definitely not at the point when you changed document focus). It was the crop tool I think, if that matters. The backtrace above indicates there was also a canvas switch involved, so I'll attach my backtrace. Created attachment 147877 [details]
Crash after closing another document and switching tools
That looks like there's somehow an invalid or null pointer in the list of actions.
changing
if (action->property("tool_action").isValid()) {
into
if (action && action->property("tool_action").isValid()) {
should be sufficient, I guess.
The most stable build which I saved recently is git 68ad8f3, every builds after that one is so crashy for some reason. Those crashes after closing subwindows, on pasting images, even on doing nothing sometimes etc. We should first trap why a null action makes it to the canvas's list of actions. May be of interest for a git bisect, would't be surprised either if Coverity fixes only uncovered this bug instead of causing it. https://invent.kde.org/graphics/krita/-/compare/68ad8f3...master?from_project_id=206 Probably due to https://invent.kde.org/graphics/krita/-/commit/e3d359608b9d6038b2428e8a49b833e7a5188ba4#1c36f0db18ca0e87f7da1033e19d6af8d00102ab_616_615 Git commit bcff23b8f01e483fdde3807cb19eef6ad7ea4eca by L. E. Segovia. Committed on 03/04/2022 at 13:29. Pushed by lsegovia into branch 'master'. Workaround crash on null action Technically, the action *is* null. And we already are handling raw gunpowder, as UBSan says... Related: bug 451903 M +1 -1 libs/widgetutils/xmlgui/kactioncollection.cpp https://invent.kde.org/graphics/krita/commit/bcff23b8f01e483fdde3807cb19eef6ad7ea4eca *** Bug 452101 has been marked as a duplicate of this bug. *** *** Bug 452331 has been marked as a duplicate of this bug. *** *** Bug 452230 has been marked as a duplicate of this bug. *** *** Bug 452283 has been marked as a duplicate of this bug. *** |