| Summary: | Settings window of krunner has Wayland generic icon | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Alexander Lohnau <alexander.lohnau> |
| Status: | VERIFIED FIXED | ||
| Severity: | minor | CC: | nate, nicolas.fella, plasma-bugs-null, qydwhotmail, sitter |
| Priority: | NOR | Keywords: | wayland-only |
| Version First Reported In: | master | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/9a5491ef69b3f80ede4db8dc43b6067a3acddd03 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
krunner needs a NoDisplay desktop file added I'm guessing Git commit 9d2dbdb83377b67ef2bdb97bd76c5b28ba6c8576 by Alexander Lohnau. Committed on 29/03/2022 at 13:29. Pushed by alex into branch 'master'. Add desktop file with NoDisplay=true for KRunner KCM This is needed for displaying a proper icon on wayland M +1 -1 kcms/runners/CMakeLists.txt A +9 -0 kcms/runners/kcm_krunnersettings.desktop https://invent.kde.org/plasma/plasma-desktop/commit/9d2dbdb83377b67ef2bdb97bd76c5b28ba6c8576 I'm afraid this doesn't fix the problem for me. The window still has the generic wayland icon. yes, the patch is not correct. The patch was for the KRunner settings in systemsetting, but that's not the settings that this is about. This is about the newly added settings window in krunner directly. It seems like krunner already has a correctly named desktop file with an icon, so not sure why it's not working. May be a bug in the taskmanager or kwin The KCM window is opened by using KCMultiDialog. Should we use kcmshell5 instead? Yes please. :) Git commit 9a5491ef69b3f80ede4db8dc43b6067a3acddd03 by Alexander Lohnau. Committed on 29/03/2022 at 16:26. Pushed by alex into branch 'master'. Use kcmshell5 to launch KRunner KCM M +0 -1 krunner/CMakeLists.txt M +2 -7 krunner/view.cpp https://invent.kde.org/plasma/plasma-workspace/commit/9a5491ef69b3f80ede4db8dc43b6067a3acddd03 Now it's fixed! Thank you. |
Created attachment 147794 [details] screenshot STEPS TO REPRODUCE 1. use Wayland session 2. press alt+space 3. click on the leftmost button of krunner OBSERVED RESULT settings window of krunner opens with Wayland generic icon. Please see the attached screenshot. EXPECTED RESULT Settings window should have its own icon SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.24.80 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.3 Graphics Platform: Wayland