Bug 451952

Summary:	Arrow-key navigation in browse mode skips folders
Product:	[Applications] gwenview	Reporter:	Kishore Gopalakrishnan <kishore96>
Component:	general	Assignee:	Gwenview Bugs <gwenview-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahiemstra, felixernst, kde, nate, noahadvs
Priority:	HI	Keywords:	regression
Version First Reported In:	22.03.80
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:		Version Fixed/Implemented In:	22.04.0
Sentry Crash Report:

Description Kishore Gopalakrishnan 2022-03-27 09:00:45 UTC

SUMMARY
In the 'browse' view, it is no longer possible to use the arrow keys (on the keyboard) to move between folders. Arrow keys only move the focus between image files, and if the user uses the mouse to place the focus on a folder, arrow keys don't work to move the focus.

STEPS TO REPRODUCE
1. Open any folder that contains both images and folders with Gwenview.
2. Make sure you are in 'Browse' mode
3. Open an image in that folder by clicking it.
4. Press 'Esc' to go back to browse mode.
3. Repeatedly press the arrow keys (on your keyboard) to try to bring the focus to a folder

OBSERVED RESULTS
Folders are skipped during arrow-key navigation.

EXPECTED RESULTS
User should also be able to select folders while navigating with arrow keys.

SOFTWARE VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3
Kernel Version: 5.16.16-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx
Memory: 21.5 GiB of RAM
Graphics Processor: AMD Radeon Vega 8 Graphics

ADDITIONAL INFORMATION
Archives (e.g. *.tar.gz) are also affected. 

Downgrading to gwenview 21.12.3 fixes the issue

Comment 1 Nate Graham 2022-03-27 18:41:54 UTC

Oh dear, can confirm. I broke this with https://invent.kde.org/graphics/gwenview/-/commit/0c7b7bf08b4e77d54d9b830820cdcee89fb4bf17. I forgot to test that use case.

Comment 2 Nate Graham 2022-03-27 18:54:59 UTC

I don't know if my QtWidgets skills are sufficient to fix this without help. Does anyone have an idea how you fix an issue like this? Add an event filter on the grid view? Conditionally unset the shortcut?

Comment 3 Nate Graham 2022-04-04 19:10:19 UTC

Git commit bc0b3a2a694c54c2ddfd86e19f60a6800915b3b6 by Nate Graham.
Committed on 04/04/2022 at 19:08.
Pushed by ngraham into branch 'release/22.04'.

Revert "Add global scope left/right arrow key shortcuts for the view"

This reverts commit 0c7b7bf08b4e77d54d9b830820cdcee89fb4bf17.

Unfortunately this caused a regression that I could not figure out how
to fix before the 22.04 RC. Reverting it for now on the release/22.04
branch, and hopefully I will be able to fix it for 22.08.

M  +0    -2    app/mainwindow.cpp

https://invent.kde.org/graphics/gwenview/commit/bc0b3a2a694c54c2ddfd86e19f60a6800915b3b6

Comment 4 Nate Graham 2022-04-04 19:11:19 UTC

I reverted the change for the 22.04 release as there is no time left to fix it, unfortunately. Also I don't really know how to do it.

CCing Felix who might be able to help.

Comment 5 David Edmundson 2022-09-15 21:00:40 UTC

Presumably means the bug as-is is can now be closed?

Comment 6 Nate Graham 2022-09-16 18:56:20 UTC

Yeah.