Bug 451875

Summary:	Brush smoothing type isn't remembered, always defaults to None
Product:	[Applications] krita	Reporter:	tomtomtomreportingin
Component:	Tools/Freehand	Assignee:	Dmitry Kazakov <dimula73>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dimula73
Priority:	NOR	Keywords:	regression
Version:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/krita/commit/09d6693732e721f7b1f3c4c03da39ab7800b0dc1	Version Fixed In:

Description tomtomtomreportingin 2022-03-25 01:02:54 UTC

git 4d849b266a

SUMMARY
In Krita 5.1 git4d849b266a,  the brush smoothing type isn't remembered and will always default to None on a new document or session.

STEPS TO REPRODUCE
1. Set Brush Smoothing to Basic.
2. Restart Krita.
3. Observe what Brush Smoothing is set to.

OBSERVED RESULT
The brush smoothing has been reset to None.

EXPECTED RESULT
The brush smoothing type should be remembered like before.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.90.0
Qt Version: 5.12.12 (appimage)

Comment 1 Dmitry Kazakov 2022-03-28 16:35:38 UTC

This bug is a regression from aa4212b403

Comment 2 Dmitry Kazakov 2022-03-29 04:36:28 UTC

Git commit 09d6693732e721f7b1f3c4c03da39ab7800b0dc1 by Dmitry Kazakov.
Committed on 29/03/2022 at 04:36.
Pushed by dkazakov into branch 'master'.

Revert "Add option to have separate smoothing options for the brush eraser"

This reverts commit aa4212b4030d092ac6a948b3ba6e2f98a8ee63f4.

# Conflicts:
#	libs/ui/tool/kis_tool_freehand.h
#	libs/ui/tool/kis_tool_freehand_helper.cpp

M  +0    -1    libs/flake/KoDerivedResourceConverter.cpp
M  +0    -1    libs/flake/KoResourceManager_p.cpp
M  +0    -1    libs/ui/kis_derived_resources.cpp
M  +0    -13   libs/ui/tool/kis_smoothing_options.cpp
M  +0    -4    libs/ui/tool/kis_smoothing_options.h
M  +0    -8    libs/ui/tool/kis_tool_freehand.cc
M  +0    -3    libs/ui/tool/kis_tool_freehand.h
M  +3    -46   libs/ui/tool/kis_tool_freehand_helper.cpp
M  +0    -4    libs/ui/tool/kis_tool_freehand_helper.h
M  +154  -205  plugins/tools/basictools/kis_tool_brush.cc
M  +11   -36   plugins/tools/basictools/kis_tool_brush.h

https://invent.kde.org/graphics/krita/commit/09d6693732e721f7b1f3c4c03da39ab7800b0dc1