Summary: | KAboutData does not correctly indicate that later versions of the license can be used | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kcoreaddons | Reporter: | Soren Stoutner <soren> |
Component: | general | Assignee: | Michael Pyne <mpyne> |
Status: | REPORTED --- | ||
Severity: | minor | CC: | a.samirh78, kdelibs-bugs, sitter, soren |
Priority: | NOR | ||
Version: | 5.106.0 | ||
Target Milestone: | --- | ||
Platform: | Debian testing | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Soren Stoutner
2022-03-24 21:31:03 UTC
I guess you're talking about the "About AppName" action in the Help menu? that uses KAbstractAboutDialog[1], which uses KAboutLicense::name() to get the label ("License: ...") to show in the dialogue, and KLicenseDialog (the dialogue that shows the actual license text), which uses KAboutLicense::text(). Neither name() nor text() consider KAboutLicense::OrLaterVersion; the latter seems to affect the return value of KAboutLicense::spdx() [1]https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kabstractaboutdialog_p.cpp#L84 Last I checked the enum values were a shambles and I've concluded that the API needs reinventing to instead base on spdx input and output. Everything else is awkwardly inflexible . I think we should update the API docs so that it's clear the OrLater option only concerns the spdx() method(s). |