Bug 451862

Summary:	Certain weekend holidays missing in month view
Product:	[Applications] korganizer	Reporter:	Michael Büker <mb>
Component:	monthview	Assignee:	kdepim bugs <pim-bugs-null>
Status:	CONFIRMED ---
Severity:	normal	CC:	gjditchfield
Priority:	NOR
Version First Reported In:	5.19.3
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Michael Büker 2022-03-24 18:05:56 UTC

SUMMARY
Month view (but not agenda view) appears to be missing:
- any holidays which occur on a Sunday by definition, and
- any holidays which happen to fall on a Saturday (with one unexplained exception, see below)

STEPS TO REPRODUCE
1. Enable holidays, in this example: German (Germany)
2. Inspect month view, in this example: throughout the year 2022

OBSERVED RESULT
The following holidays, which occur on a Sunday by definition, are missing:
- Beginn der Sommerzeit (27.03.2022)
- Ostersonntag (17.04.2022)
- Muttertag (08.05.2022)
- Pfingstsonntag (05.06.2022)
- Beginn der Winterzeit (30.10.2022)
- 1./2./3./4. Advent (27.11.2022, 04.12.2022, 11.12.2022, 18.12.2022)

The following holidays, which occur on Sundays in 2022 (and 2023) by accident, are SHOWN:
- 1. Mai (01.05.2022)
- 1. Weihnachtsfeiertag (25.12.2022)
- Neujahr (01.01.2023)

The following holidays, which occur on Saturdays in 2022 by accident, are missing:
- Heiliger Abend (24.12.2022)
- Silvester (31.12.2022)

As a strange exception, the following holiday on a Saturday in 2022 by accident, is SHOWN:
- Neujahr (01.01.2022)

SOFTWARE/OS VERSIONS
Linux: Kubuntu 22.04 (dev preview)
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
korganizer 5.18.1 is not affected by this bug. It was discovered while investigating Bug 451700, which affects 5.18.1, but not 5.19.3.

Whatever resolved Bug 451700 somewhere between korganizer 5.18.1 and 5.19.3 is probably closely related to this bug.

Comment 1 gjditchfield 2022-03-27 01:26:16 UTC

The month view only shows holidays that are defined as "public" holidays.
The definitions for "German (Germany)" are given at 
https://invent.kde.org/frameworks/kholidays/-/blob/master/holidays/plan2/holiday_de_de .
Neujahr is public, so it appears regardless of the weekday;
Beginn der Sommerzeit is seasonal, and never appears.
This is, arguably, odd behaviour.

Comment 2 Michael Büker 2022-03-27 09:46:02 UTC

(In reply to gjditchfield from comment #1)
> The month view only shows holidays that are defined as "public" holidays.
> The definitions for "German (Germany)" are given at 
> https://invent.kde.org/frameworks/kholidays/-/blob/master/holidays/plan2/
> holiday_de_de .
> Neujahr is public, so it appears regardless of the weekday;
> Beginn der Sommerzeit is seasonal, and never appears.
> This is, arguably, odd behaviour.

Also, it's an unexplained change from previous behavior (see Bug 451700). Ideally, the user should have a chance to configure which holidays are shown.