Bug 451786

Summary:	Zero sized images on failed move
Product:	[Applications] digikam	Reporter:	_ <myaccount132>
Component:	Database-Files	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metzpinguin
Priority:	NOR
Version First Reported In:	6.4.0
Target Milestone:	---
Platform:	Mint (Ubuntu based)
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/ed2682e23def93f94d645495a28a67c26c782437	Version Fixed/Implemented In:	7.7.0
Sentry Crash Report:

Description _ 2022-03-22 06:35:12 UTC

SUMMARY

When moving images to different drive disk space empties, there will zero sized images at target disk (combined with possible external datafiles) but actual images stay at source disk and they're not able to be moved to that location after freeing disk space as they appear to be there already. 

This could lead to deletion of images from source location (only working copies) as files may appear to be in two places. 

Haven't tested but suspecting this could occur also if moving is interrupted for some other reason too.

Comment 1 Maik Qualmann 2022-03-22 08:09:58 UTC

Git commit ed2682e23def93f94d645495a28a67c26c782437 by Maik Qualmann.
Committed on 22/03/2022 at 08:09.
Pushed by mqualmann into branch 'qt5-maintenance'.

remove possible existing file if QFile::rename fails
FIXED-IN: 7.7.0

M  +2    -1    NEWS
M  +11   -1    core/libs/threadimageio/engine/dfileoperations.cpp

https://invent.kde.org/graphics/digikam/commit/ed2682e23def93f94d645495a28a67c26c782437

Comment 2 _ 2022-03-22 15:46:00 UTC

There's also additional issue in this: *Last file* that causes the disk space to end *will be copied partially* and this also may cause user to delete wrong copy from source location and only have this faulty copy of file left as this may go unnoticed. 

Feature should *first check that sufficient space exists* at target location before trying to copy, and possibly have other warnings.

Comment 3 Maik Qualmann 2022-03-22 16:46:40 UTC

If the file is not completely copied, it remains in the source directory. This problem has already been fixed in current digiKam versions.

Maik