Bug 451678

Summary: Don't use a link to open the "What's the risk?" sheet
Product: [Applications] Discover Reporter: heqromancer
Component: discoverAssignee: Dan Leinir Turthra Jensen <leinir>
Status: RESOLVED FIXED    
Severity: wishlist CC: aleixpol, nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: https://invent.kde.org/plasma/discover/commit/6b9e35eefb4ad48555fb925d49389cd472eb1926 Version Fixed/Implemented In: 5.25
Sentry Crash Report:
Attachments: Alternative way to spawn the wall of text.

Description heqromancer 2022-03-19 08:54:18 UTC 
Created attachment 147592 [details]
Alternative way to spawn the wall of text.

SUMMARY
After skimming through Nate's "This week in KDE" blog for this week, I couldn't help but notice that a window appears when we press the "What's the risk?" link (see picture https://pointieststick.files.wordpress.com/2022/03/proprietary-app-warning-1.png?w=762&h=659 in his blog).

The way this is shown makes it look like your browser will spawn a window for the "What's the risk?" link.  

Perhaps an alternative would be having a "Help" button consisting exclusively in a flat icon alongside the "Proprietary" tag whose contextual pop-up could be "What's the risk?". The user then may expect something else to happen (like, in this case, the window spawning another inside it). I did a mockup on Krita about what I mean. I suck at Krita by the way, I just wanted to illustrate what I wrote.
Comment 1 Nate Graham 2022-03-26 03:47:24 UTC 
That would be more out-of-the-way... but maybe *too* out of the way? I want people to see the UI to open this and not miss it entirely. ToolButtons don't look clickable, especially when their icon doesn't look very icon-like.
Comment 2 Nate Graham 2022-03-26 03:55:47 UTC 
I submitted a speculative merge request for the change. We'll see what VDG folks say.
Comment 3 Nate Graham 2022-03-26 03:56:22 UTC 
(https://invent.kde.org/plasma/discover/-/merge_requests/277; the bot doesn't seem to have noticed)
Comment 4 Nate Graham 2022-03-31 17:22:36 UTC 
Git commit 6b9e35eefb4ad48555fb925d49389cd472eb1926 by Nate Graham.
Committed on 31/03/2022 at 17:22.
Pushed by ngraham into branch 'master'.

Use a button instead of a link to open the "What's the risk?" sheet

Right now this sheet is opened by clicking on a link with the text
"What's the risk?"

We got some user feedback that links scare them because it makes them
think a web browser window will open and they don't want that, and also
that links in apps that don't open webpages are weird in general.

This commit changes the UI to use a button instead, which would be a
more typical way for users to make something happen within an app.
FIXED-IN: 5.24

M  +35   -29   discover/qml/ApplicationPage.qml

https://invent.kde.org/plasma/discover/commit/6b9e35eefb4ad48555fb925d49389cd472eb1926