Summary: | rkward constantly crashes in argument hint - ktexteditor 5.92.0, but not ktexteditor 5.91.0 | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-ktexteditor | Reporter: | Francisco Cribari <cribari> |
Component: | general | Assignee: | KWrite Developers <kwrite-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | cribari, rkward-devel, thomas.friedrichsmeier, waqar.17a |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.92.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/ktexteditor/commit/ad82b876016367bd9765185dba84600985e5d0fd | Version Fixed In: | |
Sentry Crash Report: |
Description
Francisco Cribari
2022-03-16 21:32:12 UTC
Thanks for reporting.
> The crash can be reproduced every time.
You mean every time you type an instruction in the script window, you are getting the crash? Or is it "only" something that happens often? Or does this happen, when you type something specific (what)?
I have never seen this bug, before. Which does not mean it isn't real, only that I need some more info to find out, where to start looking.
(In reply to Thomas Friedrichsmeier from comment #1) > Thanks for reporting. > > > The crash can be reproduced every time. > > You mean every time you type an instruction in the script window, you are > getting the crash? Or is it "only" something that happens often? Or does > this happen, when you type something specific (what)? > > I have never seen this bug, before. Which does not mean it isn't real, only > that I need some more info to find out, where to start looking. What I mean is that the crashes happen frequently. For instance, I had over ten crashes today. I start rkward, click on File... select the option Open R Script File... and then open a file that contains R instructions. Then I execute some instructions by highlighting them and then pressing CTRL + Enter. For instance, setwd("~/courses/et588-mr2/programs/") getwd() Most crashes happen when I am typing in the script window, e.g., I type pdf(coo and then rkward crashes. Thanks for clarifying. I'll have to test with KTexteditor 5.92, maybe the problem is there. Things you can do to help track down the bug (or to work around it): - Try disabling some completion types in Settings->Configure RKWard->Script Editor. Perhaps you can pin down, which ones exactly are causing the crash. - Try compiling the git master version of RKWard. - If you have that option, try running on a system with an older version of KTextEditor. - Should you notice any pattern (e.g. fully repeatable crash on a particular instruction), please let me know (I have just tried repeatedly typing a bunch of variations of "pdf(coo", but was unable to produce a crash). (In reply to Thomas Friedrichsmeier from comment #3) > Thanks for clarifying. I'll have to test with KTexteditor 5.92, maybe the > problem is there. > > Things you can do to help track down the bug (or to work around it): > > - Try disabling some completion types in Settings->Configure RKWard->Script > Editor. Perhaps you can pin down, which ones exactly are causing the crash. > - Try compiling the git master version of RKWard. > - If you have that option, try running on a system with an older version of > KTextEditor. > - Should you notice any pattern (e.g. fully repeatable crash on a particular > instruction), please let me know (I have just tried repeatedly typing a > bunch of variations of "pdf(coo", but was unable to produce a crash). I unticked the option "Function call tip" in the "Code Completion / Code Hints" tab of Settings -> Configure RKWard... -> Script editor. Result: no crashes. I then activated back "Function call tip". Result: The crashes returned. I then unticked "Object name completion" (all other options activated). Result: No crashes. I then unticked "Auto word completion (all other options activated). Result: Crashes. I then unticked "Function argument completion (all other options activated). Result: No crashes. I then unticked "Filename completion (all other options activated). Result: Crashes. UPDATE: I've just experienced a crash with the option "Function argument completion" unticked (all other options activated). Ok, this looks like a bug in ktexteditor. I installed arch linux, getting ktexteditor 5.92.0. This results in the crash you describe. Did pacman -U https://archive.archlinux.org/packages/k/ktexteditor/ktexteditor-5.91.0-1-x86_64.pkg.tar.zst started again, and the crash went away. git bisect pins down the problem to one of the following commits: https://invent.kde.org/frameworks/ktexteditor/-/commit/cfac04723df556d492b9dea901be8411c59662cc (does not compile) https://invent.kde.org/frameworks/ktexteditor/-/commit/e1eec8e6000861de2459451e219ab322468b6906 (first commit showing the crash) Git commit ad82b876016367bd9765185dba84600985e5d0fd by Waqar Ahmed. Committed on 18/03/2022 at 05:14. Pushed by waqar into branch 'master'. Fix crash with stale indexes M +5 -0 src/completion/katecompletionmodel.cpp https://invent.kde.org/frameworks/ktexteditor/commit/ad82b876016367bd9765185dba84600985e5d0fd Hi, Pushed a possible fix. If it is still crashing feel free to reopen with some example R code if possible so that its easy to repro. Git commit ca1f3ed68bbd6173758f13a890c8fddad0c8b88e by Thomas Friedrichsmeier. Committed on 21/03/2022 at 20:42. Pushed by tfry into branch 'master'. Disable function call tip when used with ktexteditor 5.92.0 M +16 -1 rkward/windows/rkcodecompletion.cpp https://invent.kde.org/education/rkward/commit/ca1f3ed68bbd6173758f13a890c8fddad0c8b88e |