| Summary: | When Night Color has been manually disabled, only consider this to be relevant (for the purpose of the tray item's "Shown when relevant" status) when Night color would otherwise be active | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | medin <med.medin.2014> |
| Component: | Brightness and Color widget | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | materka, natalie_clarius, nate |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | 5.24.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Night Color shown when disabled and hidden when enabled
Night Color shown disabled outside time of activation |
||
When you say "enable" and "disable", are you talking about checking the checkbox in the System Settings KCM, or clicking on the icon in the System Tray? (In reply to Nate Graham from comment #1) > When you say "enable" and "disable", are you talking about checking the > checkbox in the System Settings KCM, or clicking on the icon in the System > Tray? If it's activated in KCM and you are outside time of activation, and you set Night Color widget to show only when relevant in System Tray, in this state it appears hidden in tray system but when you click on it to disable it then it becomes shown which contradicts the parameter "shown only when relevant". I don't know if it's correct or not but being relevant should be applied to only inside time of activation to show user either it's enabled or disabled. See attached video for more info. Created attachment 147739 [details]
Night Color shown disabled outside time of activation
Oh I see! In this case I think the behavior is actually intentional and correct. You have it set to "show when relevant". Right now it's not relevant since it's still daytime. But when you click on it, that disables the feature until you manually enable it again, which makes the tray item relevant since it's in a non-default state. Clear as mud? :) (In reply to Nate Graham from comment #4) > Oh I see! > > In this case I think the behavior is actually intentional and correct. > > You have it set to "show when relevant". Right now it's not relevant since > it's still daytime. But when you click on it, that disables the feature > until you manually enable it again, which makes the tray item relevant since > it's in a non-default state. > > Clear as mud? :) What I understand from a widget to be "shown when relevant" is that the icon appears when it's useful or has meaning, so night color widget icon (with option "shown when relevant") should never appear on panel outside time of activation even it's enabled or disabled, because only during time of activation the status of being enabled or disabled has meaning to user. Yeah, the definition of "relevant" is up to the app itself. I see your point, and it does make some sense. Re-opening. What is described in the bug report is with the old standalone night light applet, which has now (with Plasma 6.0) been integrated into the brightness applet instead, where it is only shown as relevant if a screen temperature change is currently in effect. Git commit 3e62265b32739e2a5846c94bb2556dcd44a2816c by Natalie Clarius. Committed on 25/03/2024 at 20:01. Pushed by nclarius into branch 'brightnessapplet-relevant-nightlight-inhibited'. applets/brightness: show as relevant if night light is inhibited ... and it would otherwise have a temperature change in effect. M +2 -1 applets/brightness/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/3e62265b32739e2a5846c94bb2556dcd44a2816c Git commit 7f8e63fe712ed2babefde3f8ccd89a75f1456237 by Natalie Clarius. Committed on 26/03/2024 at 20:52. Pushed by nclarius into branch 'master'. applets/brightness: show as relevant if night light is inhibited Provided it would otherwise have a temperature change in effect. Inhibited means it is in a non-default state, so it makes sense to keep the user aware of this. M +2 -1 applets/brightness/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/7f8e63fe712ed2babefde3f8ccd89a75f1456237 |
Created attachment 147530 [details] Night Color shown when disabled and hidden when enabled When you set Night Color widget to show only when relevant, if you enable the Night Color it becomes hidden in tray system and when you disable it it becomes shown.