| Summary: | Git master: Multiple #include-line build failures after a recent framework upgrade (culprit between March 7, 20:00 and March 14, 02:00, UTC), unknown which framework | ||
|---|---|---|---|
| Product: | [I don't know] kde | Reporter: | Duncan <1i5t5.duncan> |
| Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | bovo targetlibs patch (workaround) | ||
|
Description
Duncan
2022-03-16 05:05:01 UTC
(In reply to Duncan from comment #0) > FAILED: CMakeFiles/bovo.dir/gui/main.cc.o ... > -isystem /usr/include/KF5/KXmlGui > -isystem /usr/include/KF5 ... Hmm... I see a bunch of -isystem /usr/include/KF5/*, but what I do *NOT* see is ... -isystem /usr/include/KF5/KCoreAddons ... which has KAboutData and kaboutdata.h , which is what it can't find. What mechanism is supposed to generate that inclusion, that now isn't, and in what framework (because it's now missing in multiple apps, including bovo which only had the version bump commit, so it's gotta be below the individual package level) is it? That would appear to be the culprit framework. And why are some, including KXMLGui, still included, but others, here KCoreAddons, missing? Created attachment 147574 [details]
bovo targetlibs patch (workaround)
Why it's happening is beyond me, it's clearly below the leaf package level, but this patch at the leaf package level does at least allow bovo (as my first test package) to build again. If a dev doesn't get to it first I'll have to try to figure out why it's now necessary and fix the real problem or make workarounds for the other packages later.
Likely related: kwayland commit de442e4a9: Install Client headers in a dirs hierarchy matching the C++ namespaces which references https://mail.kde.org/pipermail/kde-frameworks-devel/2022-January/120608.html . Quoting the commit: This auto-magically worked with KF5 because <prefix>/include/KF*/ was always added to the targets interface include dirs by ECM (for compatibility with KDE4?). From the symptoms it seems ECM isn't doing that any more even on KF5. (Looking at new updates and came across that. Hopefully it means the others are caught now too and are fixed (or being fixed), and I'll catch them as I look at more updates. Maybe I'll be able to RESOLVED/FIXED, or at least narrow down the list of affected builds a bit, with my next comment.) (In reply to Duncan from comment #3) > (Hopefully it means the others > are caught now too and are fixed (or being fixed), and I'll catch them as I > look at more updates. Maybe I'll be able to RESOLVED/FIXED, or at least > narrow down the list of affected builds a bit, with my next comment.) Bovo seems to have (independently) committed the exact patch I suggested as a workaround in comment #2, as 6c8142100 . And plasma-workspace seems to have done something similar, and I think there are others tho not all of them yet. So it seems the fixes are going into the individual repos/packages. I'll probably eventually close this and open bugs against the individual packages that aren't yet fixed, but will leave it open for now so I can more easily find and reference it as I file the others. So closing this generic bug RESOLVED/INTENTIONAL as it appears it's just that at the frameworks level and people are supposed to do their own includes now. And since I'm filing bugs on the remaining-to-be-fixed individual packages now this one should be closed.. |