Bug 451461

Summary:	Rescan of translation memory never finishes in the GUI
Product:	[Applications] lokalize	Reporter:	Frank Steinmetzger <dev+kde>
Component:	translation memory	Assignee:	Simon Depiets <sdepiets>
Status:	RESOLVED FIXED
Severity:	normal	CC:	fin-w, kishore96, shafff, vit
Priority:	NOR
Version First Reported In:	21.12.3
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/sdk/lokalize/-/commit/aa584b665bb2c0d8bf8468dbc704dab66f236e05	Version Fixed/Implemented In:
Sentry Crash Report:

Description Frank Steinmetzger 2022-03-13 17:39:25 UTC

STEPS TO REPRODUCE
1. Load a project
2. Start a full project rescan
3. The scan starts, its progress is shown both in the task bar item and in a plasma notification

OBSERVED RESULT
After a files have been processed, the progress never changes to the finished state, i.e. the “progress bar” in the task bar remains at 100 % and the notification shows a Stop button.

EXPECTED RESULT
The notification should change its text to a “Finished reading %1 files“ message, hide the Stop button and ultimately go away by itself.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.24.3
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.16.13-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-4590 CPU @ 3.30GHz
Memory: 31.0 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600

Comment 1 Finley Watson 2024-03-13 07:30:56 UTC

*** Bug 483406 has been marked as a duplicate of this bug. ***

Comment 2 Finley Watson 2024-03-13 07:33:43 UTC

Setting to confirmed as this exists in version 24.02.0 as well (see duplicate bug report).

Comment 3 Albert Astals Cid 2024-08-25 10:48:34 UTC

Git commit ac2efe7a07263e6708073bea78851918b4541d46 by Albert Astals Cid.
Committed on 25/08/2024 at 10:48.
Pushed by aacid into branch 'master'.

Fix Translation Memory import job not finishing

The fix is two-fold:
 * We need to call deleteLater on the subjobs so they are actually
   destroed
 * There's two places that create ScanJobFeedingBack jobs but only one
   of them connected to the destroyed signal, add it to the other one

M  +6    -6    src/tm/tmscanapi.cpp

https://invent.kde.org/sdk/lokalize/-/commit/ac2efe7a07263e6708073bea78851918b4541d46

Comment 4 Albert Astals Cid 2024-08-27 20:22:09 UTC

Git commit aa584b665bb2c0d8bf8468dbc704dab66f236e05 by Albert Astals Cid.
Committed on 27/08/2024 at 20:22.
Pushed by aacid into branch 'release/24.08'.

Fix Translation Memory import job not finishing

The fix is two-fold:
 * We need to call deleteLater on the subjobs so they are actually
   destroed
 * There's two places that create ScanJobFeedingBack jobs but only one
   of them connected to the destroyed signal, add it to the other one
(cherry picked from commit ac2efe7a07263e6708073bea78851918b4541d46)

M  +6    -6    src/tm/tmscanapi.cpp

https://invent.kde.org/sdk/lokalize/-/commit/aa584b665bb2c0d8bf8468dbc704dab66f236e05

Comment 5 Albert Astals Cid 2024-08-27 20:22:36 UTC

*** Bug 491782 has been marked as a duplicate of this bug. ***